New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI/Vue: add interactions to vue cli template #18021
CLI/Vue: add interactions to vue cli template #18021
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e69896d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Thanks for your contribution @italoteix! Unfortunately it seems like the Vue rendering engine has some sort of delay which ends up impacting the tests that ran in the play function, so they fail. I'm not sure what to do here |
…ithub.com/italoteix/storybook into feat/add-interactions-to-vue-cli-template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is good! It surfaces an issue with the vue2 renderer (might be related to how it handles args before rendering stories), but overall the PR is all good! Thanks @italoteix
Issue: #16722
What I did
Similar to PR #17345. Added interactions to Vue cli template.
How to test
Build cli locally and run repro to select Vue as a framework
If your answer is yes to any of these, please make sure to include it in your PR.