Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI/HTML: Add interactions to cli template #18014

Merged
merged 3 commits into from Apr 25, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 20, 2022

Issue: #16722

What I did

Much like #17345, I added addon interactions to the HTML template in the CLI

How to test

Build cli locally and run sb repro to select html as a framework, or run sb init

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added feature request ci: do not merge cli patch:yes Bugfix & documentation PR that need to be picked to main branch html addon: interactions labels Apr 20, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 20, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 526d434. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf
Copy link
Member Author

yannbf commented Apr 20, 2022

Blocking this one as it's having the same issue as the Ember PR. I'll look further into the user-event issue

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 071501d into next Apr 25, 2022
@shilman shilman deleted the feat/add-interactions-to-html-cli-template branch April 25, 2022 09:49
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: interactions cli feature request html patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants