Use predefined PHP float epsilon #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using an arbitrary epsilon, use the predefined PHP constant PHP_FLOAT_EPSILON, which is defined to be the smallest representable positive number "x", such that "x + 1.0 != 1.0". See https://www.php.net/manual/en/reserved.constants.php#constant.php-float-epsilon for additional information.
|
Thanks! |
1 task
localheinz
reviewed
Jan 24, 2022
| @@ -67,7 +62,7 @@ public function evaluate($other, string $description = '', bool $returnResult = | |||
| if (is_float($this->value) && is_float($other) && | |||
| !is_infinite($this->value) && !is_infinite($other) && | |||
| !is_nan($this->value) && !is_nan($other)) { | |||
| $success = abs($this->value - $other) < self::EPSILON; | |||
| $success = abs($this->value - $other) < PHP_FLOAT_EPSILON; | |||
There was a problem hiding this comment.
Nice, @marijnvanwezel!
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 18, 2022
This PR was merged into the 4.4 branch. Discussion ---------- [Stopwatch] Fix test expectation | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This test doesn't pass anymore because of sebastianbergmann/phpunit#4874 released in PHPUnit 9.5.14. Commits ------- 11c1381 [Stopwatch] Fix test expectation
rez1dent3
added a commit
to bavix/laravel-wallet
that referenced
this pull request
Feb 18, 2022
Mellthas
added a commit
to dompdf/dompdf
that referenced
this pull request
Mar 3, 2022
`assertSame` uses a stricter epsilon since version 9.5.14 (absolute `PHP_FLOAT_EPSILON`), see sebastianbergmann/phpunit#4874. Just rely on the recently introduced `Helpers::lengthEqual` for length comparison.
Mellthas
added a commit
to dompdf/dompdf
that referenced
this pull request
Mar 3, 2022
`assertSame` uses a stricter epsilon since version 9.5.14 (absolute `PHP_FLOAT_EPSILON`), see sebastianbergmann/phpunit#4874. Just rely on the recently introduced `Helpers::lengthEqual` for length comparison.
Mellthas
added a commit
to dompdf/dompdf
that referenced
this pull request
Mar 4, 2022
`assertSame` uses a stricter epsilon since version 9.5.14 (absolute `PHP_FLOAT_EPSILON`), see sebastianbergmann/phpunit#4874. Just rely on the recently introduced `Helpers::lengthEqual` for length comparison.
|
In case someone stumbles upon this: This was breaking one assertion in our project which looked like this: self::assertSame(1.2345, (12.345/10));Here's the failure message: Quote from @sebastianbergmann:
(source, take also a look at the docs) Changing this like so fixed the problem: self::assertEqualsWithDelta(1.2345, (12.345/10), 0.0001);Another way would be to convert that to a string using self::assertSame('1.2345', sprintf('%.4f',12.345/10)); |
sanmai
added a commit
to sanmai/pipeline
that referenced
this pull request
Sep 2, 2022
eerison
pushed a commit
to eerison/rector-phpunit
that referenced
this pull request
Sep 26, 2023
eerison
pushed a commit
to eerison/rector-phpunit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using an arbitrary epsilon, use the predefined PHP constant PHP_FLOAT_EPSILON, which is defined to be the smallest representable positive number "x", such that "x + 1.0 != 1.0".
See https://www.php.net/manual/en/reserved.constants.php#constant.php-float-epsilon for additional information.