New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Php80Test::testFdiv() #393
Conversation
This reminds me symfony/symfony#45475 /cc @sebastianbergmann is that legit? |
@nicolas-grekas no)) |
@nicolas-grekas your question to Sebastian is incorrect: this package use PhpUnit 5-6, sebastianbergmann/phpunit#4874 is PhpUnit 8 |
This PR is definitely motivated by sebastianbergmann/phpunit#4874 |
Issue fixed in a932445 |
@nicolas-grekas this PR motivated by https://github.com/symfony/polyfill/runs/5367868196?check_suite_focus=true |
what do you mean? yes it is, see newest CI runs as a proof. |
@nicolas-grekas this PR too do this, but you close it and update test data instead using correct assertion. |
This PR works around the test data, which was wrong in the first place. We want an exact check, not an approximation here. |
@nicolas-grekas sorry, my fail |
Need using
$this->assertEqualsWithDelta()
to compare float values.Why not use
$this->assertEquals()
or$this->assertSame()
? Because(0.1 * 0.1) / 0.1
not equal 0.1, it's ~0.10000000000000002