Use predefined PHP float epsilon #4873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using an arbitrary epsilon, use the predefined PHP constant PHP_FLOAT_EPSILON, which is defined to be the smallest representable positive number "x", such that "x + 1.0 != 1.0". See https://www.php.net/manual/en/reserved.constants.php#constant.php-float-epsilon for additional information.
Codecov Report
@@ Coverage Diff @@
## 9.5 #4873 +/- ##
=========================================
Coverage 84.08% 84.08%
Complexity 4631 4631
=========================================
Files 274 274
Lines 12683 12683
=========================================
Hits 10665 10665
Misses 2018 2018
Continue to review full report at Codecov.
|
|
Can you send this against |
|
@sebastianbergmann Thanks, I'll make a new PR for this, since this one is based on |
|
Closed in favour of #4874 (see comment above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using an arbitrary epsilon, use the predefined PHP constant PHP_FLOAT_EPSILON, which is defined to be the smallest representable positive number "x", such that "x + 1.0 != 1.0".
See https://www.php.net/manual/en/reserved.constants.php#constant.php-float-epsilon for additional information.