New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace decimal delta value for PHP_FLOAT_EPSILON #263

Merged

TomasVotruba merged 1 commit into rectorphp:main from eerison:replace-decimal-delta-value-for-constant

Sep 26, 2023

Contributor

eerison commented Sep 26, 2023 •

edited

In php 7.2 was introduced PHP_FLOAT_EPSILON and I could use this as a small representation for decimal delta.

sebastianbergmann/phpunit#4874
sebastianbergmann/phpunit#3159 (comment).

and I tested with diffident values and it worked as expected.


          Fix/Replace decimal delta value for PHP_FLOAT_EPSILON

5b2fc5c

- sebastianbergmann/phpunit#4874

eerison force-pushed the replace-decimal-delta-value-for-constant branch from 0a6a84b to 5b2fc5c Compare

September 26, 2023 09:46

eerison changed the title ~~Fix/Replace decimal delta value for PHP_FLOAT_EPSILON~~ Replace decimal delta value for PHP_FLOAT_EPSILON

TomasVotruba merged commit d9f1f10 into rectorphp:main

5 checks passed

Member

TomasVotruba commented Sep 26, 2023

This looks great, thanks for investigating 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment