Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update friendlier terminology in Gem::SafeYAML #2463

Merged
merged 1 commit into from Nov 11, 2018
Merged

Update friendlier terminology in Gem::SafeYAML #2463

merged 1 commit into from Nov 11, 2018

Conversation

JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented Nov 10, 2018

Use better terminology in Gem::SafeYAML, depends on ruby/psych#378.

Problem

These outdated terms could be offensive and harder to understand.

Description:

This Pull Request updates lib/rubygems/safe_yaml.rb.

Permitted is easier to understand and better terminology.

Original motivation, other community efforts examples:


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

use better terminology
@bronzdoc
Copy link
Member

👍 after https://github.com/dtao/safe_yaml/pull/93/files is merged

@hsbt
Copy link
Member

hsbt commented Nov 10, 2018

This depends on ruby/psych#378. I will merge this after merging it.

@hsbt
Copy link
Member

hsbt commented Nov 10, 2018

I merged ruby/psych#378 into ruby/ruby@db3101f. After updating ruby-head binary of Travis CI, I'm going to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants