Use friendlier terminology in _leaf_helpers.erb #2009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki24
reviewed
Nov 9, 2018
| @@ -18,16 +18,16 @@ leafness_of_getglobal(VALUE gentry) | |||
| else { | |||
| /* We cannot write this function using a switch() because a | |||
| * case label cannot be a function pointer. */ | |||
| static rb_gvar_getter_t *const whitelist[] = { | |||
| static rb_gvar_getter_t *const allowlist[] = { | |||
There was a problem hiding this comment.
I found this comment and here suggest allowlist. What do you think?
This was referenced Nov 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates
tool/ruby_vm/views/_leaf_helpers.erb.Allowlist is easier to understand and better terminology.
Original motivation, community efforts examples: