Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminology in test description from completion spec #1875

Closed
wants to merge 1 commit into from
Closed

Update terminology in test description from completion spec #1875

wants to merge 1 commit into from

Conversation

@JuanitoFatas
Copy link
Contributor Author

Test failure seems unrelated:

Failures:

  1) show-doc should work even if #call is defined on Symbol
     Failure/Error: Symbol.instance_eval { define_method(:call, call_method) } if call_method
     
     TypeError:
       wrong argument type NilClass (expected Proc/Method)
     # ./lib/pry/command.rb:444:in `block in use_unpatched_symbol'
     # ./lib/pry/command.rb:444:in `use_unpatched_symbol'
     # ./lib/pry/command.rb:433:in `call_safely'
     # ./lib/pry/command.rb:371:in `process_line'
     # ./lib/pry/command_set.rb:365:in `process_line'
     # ./lib/pry/pry_instance.rb:407:in `process_command'
     # ./lib/pry/testable/pry_tester.rb:24:in `block in eval'
     # ./lib/pry/testable/pry_tester.rb:17:in `eval'
     # ./lib/pry/testable/evalable.rb:13:in `pry_eval'
     # ./spec/commands/show_doc_spec.rb:24:in `block in <main>'

Finished in 21.1 seconds (files took 1.73 seconds to load)
1194 examples, 1 failure, 2 pending

Failed examples:

rspec ./spec/commands/show_doc_spec.rb:22 # show-doc should work even if #call is defined on Symbol

@kyrylo
Copy link
Member

kyrylo commented Nov 11, 2018

This change should've probably been in #1874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants