Use clearer terminologies

[JuanitoFatas]

This Pull Request updates terminology in the codebase:

• Deprecate Pry.config.exception_whitelist, use Pry.config.unrescued_exceptions instead.
• Deprecate Pry::DEFAULT_EXCEPTION_WHITELIST, use Pry::DEFAULT_UNRESCUED_EXCEPTIONS instead.

White and black are not clear, use clearer unrescued as suggested.

Original motivation, other community efforts examples:

• [ci skip] change all instances of blacklist and whitelist to denylist… rails/rails#33681
• deserialize_jsonapi not found on controller graphiti-api/graphiti#10
• Finish converting whitelist and blacklist references rails/rails#33718
• Use friendlier terminology in YAML.safe_load ruby/psych#378
• Use friendlier terminology in rubysocket.h ruby/ruby#2008
• Use friendlier terminology in _leaf_helpers.erb ruby/ruby#2009
• Use permitted in line_length.rb rubocop/rubocop#6464
• Update friendlier terminology in Gem::SafeYAML rubygems/rubygems#2463
• Update terminologies dtao/safe_yaml#93
• Introduce Request::ALLOWED_SCHEMES and deprecate existing constant rack/rack#1314
• Update terminology in http_status.rb rubocop/rubocop#6466
• Update terminology in rails/validation.rb rubocop/rubocop#6467
• Update terminology in BUILD_DETAIL.md rspec/rspec-core#2576
• Update terminology in BUILD_DETAIL.md rspec/rspec-expectations#1083
• Update terminology in BUILD_DETAIL.md rspec/rspec-mocks#1246
• Update terminology in BUILD_DETAIL.md rspec/rspec-support#356
• Use safelist(s), allowlist(s) where applicable flavorjones/loofah#158
• Update terminology in test description from completion spec #1875

[0x1eef]

i don't think allowlist or whitelist communicates the purpose of this configuration option as clearly as: unrescuable_exceptions. wdyt?

[kyrylo]

Neither https://twitter.com/dhh/status/1032050325513940992 nor
rails/rails#33677 explain the issue with these terms. It says "there's a problem" but it was never specified what exactly is wrong.

I assume that there's some potential issue involving races. I checked https://en.wikipedia.org/wiki/Blacklisting#Origins_of_the_term and didn't see any connections to race. This term is used not only in computing but in other contexts, too.

I guess I am missing something obvious here. I'd appreciate some background.

[0x1eef]

@kyrylo
do you think whitelist is a good description for this configuration option though? how is it acting as a whitelist? it is an array of exceptions who Pry::RescuableException considers 'unrescuable' and lets them fall through to the next rescue clause or raise upwards on the call stack. i don't see how "whitelist" applies as a word that describes this.

[0x1eef]

i would even think it should not be a configuration option at all but part of a public Pry::RescuableException API, like:

Pry::RescuableException.dont_rescue SomeError

[kyrylo]

I do find this hard to understand:

# Don't catch these exceptions
DEFAULT_EXCEPTION_WHITELIST

I wouldn't be opposed to the name ALLOWED_EXCEPTIONS and Pry.config.allowed_exceptions if that makes people happy. That said, I'm still curious what's wrong with white/black-lists 😁

[0x1eef]

i would vote for unrescued_exceptions or something along those lines, allowed_* doesn't communicate what this is for to me.

[0x1eef]

ditto on DEFAULT_UNRESCUED_EXCEPTIONS

[0x1eef]

'unrescued' seems like the perfect word for this.
https://en.oxforddictionaries.com/definition/unrescued

[0x1eef]

lgtm, thoughts @kyrylo ?

[kyrylo]

Nice work, it reads much better now!
P.S. I'm still not sure what's wrong with the old terms though, but whatever, I guess 😄