[#9760] Allow passing range as a positional argument to RangeHelp#range_with_surrounding_space #10748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace For consistency with other methods
This was referenced Jun 24, 2022
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jun 24, 2022
As introduced in rubocop/rubocop#10748
3 tasks
pirj
added a commit
to pirj/rubocop-rails
that referenced
this pull request
Jun 24, 2022
5 tasks
|
Looks good to me. Thanks! |
pirj
deleted the
9760-allow-passing-range-as-a-positional-argument-in-range_help-range_with_surrounding_space
branch
bquorning
reviewed
Jun 25, 2022
| def range_with_surrounding_space(range:, side: :both, | ||
| newlines: true, whitespace: false, | ||
| continuations: false) | ||
| NOT_GIVEN = Module.new |
There was a problem hiding this comment.
Just curious – why is NOT_GIVEN a module and not e.g. a symbol?
There was a problem hiding this comment.
Module.new == Module.new evaluates to false. Chances of someone passing a :not_given positional argument are nearing zero, but anyway.
pirj
added a commit
to pirj/rubocop-rails
that referenced
this pull request
Jun 27, 2022
pirj
added a commit
to pirj/rubocop-rails
that referenced
this pull request
Jun 27, 2022
pirj
added a commit
to pirj/rubocop-rails
that referenced
this pull request
Jun 27, 2022
pirj
added a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Dec 29, 2022
As introduced in rubocop/rubocop#10748
ydah
pushed a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 13, 2023
As introduced in rubocop/rubocop#10748
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
As introduced in rubocop/rubocop#10748
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
As introduced in rubocop/rubocop#10748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9760
Prequel to #10729 and #10727
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.