Pass range as a positional arg #729
Conversation
|
The change is released in RuboCop 1.31.0. Can you please kick off the build? Should be green now. |
|
I will take some time to merge and release later because it is to bump the required RuboCop version. (That is, it has user impact.) Can you add a changelog entry? |
Well, reducing the user impact is something we've tried solving with introducing the |
pirj
force-pushed
the
pass-range-as-a-positional-argument-in-range_help-range_with_surrounding_space
branch
2 times, most recently
from
b9c28f7
to
6caca55
Compare
pirj
force-pushed
the
pass-range-as-a-positional-argument-in-range_help-range_with_surrounding_space
branch
from
25fe8fb
to
757e9e4
Compare
|
The current RuboCop Rails requires the minimum RuboCop version 1.7. This change is a refactoring and has no significant benefit to users updating to the latest 1.31 (e.g. bug fixes). That's why it takes a little time to merge this PR. That said, it's probably going to be merged and released in the next minor release. I'll never forget this PR, so I'll take the opportunity to merge it. Thank you. |
|
Fair enough 👍
Sounds great. I didn't expect this to become a part of a patch release in any case 👍 |
Follow up rubocop/rubocop#10699. `ActiveSupportExtensionsEnabled` option is supported since RuboCop 1.31.0. Please merge rubocop#729 first.
|
Thanks! |
pirj
deleted the
pass-range-as-a-positional-argument-in-range_help-range_with_surrounding_space
branch
As rubocop/rubocop#10748 allows
The CI will be red until the above PR is not merged and released
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code. - againstrubocopPR as dependency{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.