Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RangeHelp consistent #9760

Closed
dvandersluis opened this issue May 2, 2021 · 3 comments
Closed

Make RangeHelp consistent #9760

dvandersluis opened this issue May 2, 2021 · 3 comments
Assignees
@dvandersluis
Labels
breaking-change refactoring
Milestone
2.0

Comments

@dvandersluis
Copy link
Member

All methods in RangeHelp that take a range do so with a positional argument, other than range_with_surrounding_space which uses a kwarg. For consistency, range_with_surrounding_space should also use a positional argument.

Changing the signature of this method will impact other RuboCop extensions which will have to be updated, so 2.0 may be a good time to do this.
@dvandersluis dvandersluis added this to the 2.0 milestone May 2, 2021
@dvandersluis dvandersluis self-assigned this May 2, 2021
This was referenced Jun 19, 2022
Open
Closed
pirj added a commit to pirj/rubocop that referenced this issue Jun 20, 2022
@pirj
[rubocop#9760] Deprecate range kwarg in range_with_surrounding_space
29ad62b
pirj added a commit to pirj/rubocop that referenced this issue Jun 24, 2022
@pirj
[rubocop#9760] Allow positional range arg in range_with_surrounding_s…
1ebe60d 
…pace

For consistency with other methods
@pirj pirj mentioned this issue Jun 24, 2022
Merged
8 tasks
bbatsov pushed a commit that referenced this issue Jun 25, 2022
@pirj @bbatsov
[#9760] Allow positional range arg in range_with_surrounding_space
bdd1d1f 
For consistency with other methods
@pirj
Copy link
Member

pirj commented Aug 7, 2022

RangeHelp is now pretty consistent. We may eventually want to deprecate the old kwarg, but it's not for 2.0.
Should we keep this to remember of would willingness to deprecate kwarg, or close this ticket?

@pirj
Copy link
Member

pirj commented Oct 12, 2022

Can we consider this done?

@dvandersluis
Copy link
Member Author

Seems done to me! Thanks @pirj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvandersluis dvandersluis

Labels
breaking-change refactoring
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

[Fixes #9760] Make RangeHelp#range_with_surrounding_space params consistent pirj/rubocop
2 participants
@pirj @dvandersluis