Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass range as a positional arg #1305

Conversation

pirj
Copy link
Member

@pirj pirj commented Jun 24, 2022

As introduced in rubocop/rubocop#10748

Since RuboCop with this PR wasn't released yet, the CI will be red.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit). - locally, against the rubocop PR

@pirj pirj self-assigned this Jun 24, 2022
@bquorning
Copy link
Collaborator

I think this PR needs a mention in the changelog, just like #1181.

We should also ask:

  1. Do we want to incorporate more newly added RuboCop features, when we do the requirement bump anyway?
  2. Do we want to do the requirement just now, or is this a PR that we should wait a month before merging/releasing?

@pirj pirj marked this pull request as ready for review June 27, 2022 07:33
@pirj pirj requested a review from Darhazer June 27, 2022 07:33
@pirj
Copy link
Member Author

pirj commented Jun 27, 2022

@pirj
Copy link
Member Author

pirj commented Jun 27, 2022

Do we want to incorporate more newly added RuboCop features, when we do the requirement bump anyway?

Yes. But I'm not aware of any.

wait a month before merging/releasing

Why? Not to force users into rubocop 1.31.0 and to wait for 1.31.1 that would probably include bugfixes?

@bquorning
Copy link
Collaborator

Why? Not to force users into rubocop 1.31.0 and to wait for 1.31.1 that would probably include bugfixes?

🤷🏼 I guess there’s no good reason to wait 😄

@bquorning bquorning merged commit 5928b3d into master Jun 27, 2022
@bquorning bquorning deleted the pass-range-as-a-positional-argument-in-range_help-range_with_surrounding_space branch June 27, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants