Release 2.0 #1055

pirj · 2020-10-22T17:31:25Z

Prepare for a 2.0 release.

This PR is to track the changes in release-2.0 branch, which is purposed to integrate remaining PRs targeted for 2.0.

To avoid name and department clash issues, RuboCop decided to grant each extension its own department. For those cops that already have the department matching the extension name, no changes are needed. More info rubocop/rubocop#8490 The changed cop names are: * `Capybara/CurrentPathExpectation` -> `RSpec/Capybara/CurrentPathExpectation` * `Capybara/FeatureMethods` -> `RSpec/Capybara/FeatureMethods` * `Capybara/VisibilityMatcher` -> `RSpec/Capybara/VisibilityMatcher` * `FactoryBot/AttributeDefinedStatically` -> `RSpec/FactoryBot/AttributeDefinedStatically` * `FactoryBot/CreateList` -> `RSpec/FactoryBot/CreateList` * `FactoryBot/FactoryClassName` -> `RSpec/FactoryBot/FactoryClassName` * `Rails/HttpStatus` -> `RSpec/Rails/HttpStatus`

Add an uber-department

Release v2.0.0-pre, compatible with RuboCop v1.0

Only dots are used when separating versions in Rubygems.

Why? - it was slow #925 (comment) - it ignored non-describe top-level example groups #925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - #932 - #977

Remove old Cop baseclass

Retire TopLevelDescribe

Fixes #938

lib/rubocop/rspec/version.rb

Retire RSpec/InvalidPredicateMatcher

bquorning · 2020-10-22T20:21:04Z

pirj · 2020-10-22T20:28:33Z

Awesome!

I can take care of making final touches to #956. I really hope it doesn't interfere with #942 😱

bquorning · 2020-10-22T20:32:06Z

Would you like me to take a stab at rebasing #942?

bquorning · 2020-10-22T20:38:21Z

I can take care of making final touches to #956. I really hope it doesn't interfere with #942 😱

It looks like there will only be conflicts in lib/rubocop/rspec/top_level_group.rb and lib/rubocop/rspec/variable.rb. It looks like minor stuff. I think it’s still worth it to work in parallel. You take #956, I take #942.

pirj · 2020-10-22T21:01:52Z

Sounds good 👍

This moves several files to a new `mixins/` folder. I was going to add some new macros, per [this comment][1], but thought it might clutter things up a bit to put them in the root folder. I thought of adding a `macros/` folder, but decided to emulate the [rubocop source][2] instead. [1]: #934 (comment) [2]: https://github.com/rubocop-hq/rubocop/tree/master/lib/rubocop/cop/mixin

* Add shared context for all cop specs. * Remove redundant `config` metadata for cop specs. * Remove redundant `cop` subjects from cop specs.

Fix find_all_in_scope method docs

Add mixins folder

Use config context for all cop specs

bquorning · 2020-10-23T20:06:06Z

@pirj I wish GitHub offered a way of communicating 1:1, synchronously 😄 I’ll try signing onto gitter.im, you can catch me there if you want.

'autocorrect' shared example group does not pass a correct file name to the cop, and if this cop is tweaked to only inspect factories, this spec fails because the default file name/path is skipped, since it's not a factory path.

Refactor a spec

lib/rubocop/cop/rspec/multiple_expectations.rb:73:32: W: Lint/ToEnumArguments: Ensure you correctly provided all the arguments. expectations_count = to_enum(:find_expectation, node).count ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ We'd still love to use OUR new cops while working on our codebase, let's see how this option works when set under RSpec namespace when we introduce the first pending cop.

Stop using newly added cops

Remove relevance detection code

RSpec aliases runtime matchers

The customization is now made via .rubocop.yml configuration, i.e.: RSpec: Language: Includes: Example: - it_has_special_behavior

…tomization Drop RSpec/EmptyExampleGroup customization

Enable pending cop(s)

It reads nicer, and `flog` agrees. Before: ❯ flog lib/rubocop/cop/rspec/mixin/top_level_group.rb 29.7: flog total 5.0: flog/method average 9.8: RuboCop::Cop::RSpec::TopLevelGroup#top_level_nodes lib/rubocop/cop/rspec/mixin/top_level_group.rb:36-44 7.6: RuboCop::Cop::RSpec::TopLevelGroup#on_new_investigation lib/rubocop/cop/rspec/mixin/top_level_group.rb:10-16 4.9: RuboCop::Cop::RSpec::TopLevelGroup#top_level_groups lib/rubocop/cop/rspec/mixin/top_level_group.rb:20-22 After: ❯ flog lib/rubocop/cop/rspec/mixin/top_level_group.rb 25.8: flog total 4.3: flog/method average 7.2: RuboCop::Cop::RSpec::TopLevelGroup#top_level_nodes lib/rubocop/cop/rspec/mixin/top_level_group.rb:35-44 6.3: RuboCop::Cop::RSpec::TopLevelGroup#on_new_investigation lib/rubocop/cop/rspec/mixin/top_level_group.rb:10-15 4.9: RuboCop::Cop::RSpec::TopLevelGroup#top_level_groups lib/rubocop/cop/rspec/mixin/top_level_group.rb:19-21

Add v2 update docs

Use `case` instead of `if`

bquorning · 2020-11-05T12:42:51Z

I added a commit to bump the version number to 2.0.0. Are we ready? Are there any easy-peasy bugfix PRs that we want to also merge in?

Should we link to @pirj ’s upgrade document (presumably on https://docs.rubocop.org/rubocop-rspec/2.0/upgrade_to_version_2.html ) directly from the changelog too?

pirj · 2020-11-05T13:07:39Z

Should we link to @pirj ’s upgrade document

Great idea!

Are we ready?

YES! 🚀 🙌

Darhazer · 2020-11-05T13:30:23Z

I guess this should be fixed first

rubocop-rspec.gemspec

- Add explicit dependency on rubocop-ast >= 1.1.0. - Rename the "Change log" to "Changelog". - Remove mention of "potentially breaking" changes. All changes between 1.x and 2.0 should be regarded as potentially breaking, so no need to highlight one over the rest. - Link to the upgrade document from README.

pirj · 2020-11-06T08:06:12Z

@Darhazer, green light for the release?

pirj · 2020-11-06T10:32:03Z

Hey @backus!

Summoning you not only to notify you about an upcoming major version release of a child of yours.
We seem to lack CodeClimate keys, do you mind to invite @bquorning, @Darhazer and myself @pirj there as collaborators?

Darhazer · 2020-11-06T15:08:27Z

@Darhazer, green light for the release?

I trust you @pirj and @bquorning on this one. Release at your will and thank you for the hard work to make it happen 🎉

bquorning · 2020-11-06T16:42:19Z

Did I miss anything? Except saying a bit thank you to everyone who helped getting us this far.

pirj · 2020-11-06T16:45:15Z

Awesome! Congrats with the release, guys!

pirj · 2020-11-06T18:02:39Z

Closed a dozen tickets, mostly thanks to #956 🎉

bquorning and others added 5 commits October 21, 2020 22:54

Require Rubocop >= 1.0

5e8e32f

Merge pull request #1019 from rubocop-hq/uber-department

0f09adb

Add an uber-department

Release v2.0.0-pre, compatible with RuboCop v1.0

e4db5ec

Merge pull request #1054 from rubocop-hq/release

28d7d9c

Release v2.0.0-pre, compatible with RuboCop v1.0

pirj added this to the 2.0 milestone Oct 22, 2020

bquorning and others added 6 commits October 22, 2020 20:38

Rename 2.0.0-pre to 2.0.0.pre

ec9c8b9

Only dots are used when separating versions in Rubygems.

Retire TopLevelDescribe

b08c95b

Why? - it was slow #925 (comment) - it ignored non-describe top-level example groups #925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - #932 - #977

Remove deprecated class ::RuboCop::Cop::RSpec::Cop

1af1ec2

Merge pull request #968 from rubocop-hq/remove-old-cop-baseclass

1b9b8a2

Remove old Cop baseclass

Merge pull request #978 from rubocop-hq/retire-top_level_describe

15aa5d3

Retire TopLevelDescribe

Retire RSpec/InvalidPredicateMatcher

f2d59bb

Fixes #938

pirj commented Oct 22, 2020

View reviewed changes

lib/rubocop/rspec/version.rb Outdated Show resolved Hide resolved

Merge pull request #940 from rubocop-hq/reture-invalid-predicate-cop

21e4cb7

Retire RSpec/InvalidPredicateMatcher

mockdeep and others added 6 commits October 22, 2020 23:39

Use config context for all cop specs

45bd976

* Add shared context for all cop specs. * Remove redundant `config` metadata for cop specs. * Remove redundant `cop` subjects from cop specs.

Fix find_all_in_scope method docs

6a6a367

Merge pull request #1060 from rubocop-hq/fix-documentation

b42f401

Fix find_all_in_scope method docs

Merge pull request #1056 from rubocop-hq/rf-mixins

912ae66

Add mixins folder

Merge pull request #1059 from rubocop-hq/cop-specs-config-metadata

5e23ee2

Use config context for all cop specs

pirj and others added 4 commits October 28, 2020 01:25

Refactor a spec

9ea14b9

'autocorrect' shared example group does not pass a correct file name to the cop, and if this cop is tweaked to only inspect factories, this spec fails because the default file name/path is skipped, since it's not a factory path.

Merge pull request #1064 from rubocop-hq/refactor-a-spec

abe73f0

Refactor a spec

Merge pull request #1065 from rubocop-hq/stop-using-edge-cops

d0588f2

Stop using newly added cops

bquorning and others added 13 commits October 29, 2020 12:58

Merge pull request #1063 from rubocop-hq/remove-relevance-detection-code

2cd7639

Remove relevance detection code

Implement dynamic matchers

e515d21

Merge pull request #956 from sl4vr/rspec-aliases_runtime-matchers

13cb62f

RSpec aliases runtime matchers

Remove customization from RSpec/EmptyExampleGroup

2e3ed04

The customization is now made via .rubocop.yml configuration, i.e.: RSpec: Language: Includes: Example: - it_has_special_behavior

Merge pull request #1007 from rubocop-hq/drop-empty-example-group-cus…

a434245

…tomization Drop RSpec/EmptyExampleGroup customization

Enable pending cop(s)

06d6abd

Merge pull request #1071 from rubocop-hq/enable-pending-2.0-cops

9a5d604

Enable pending cop(s)

Add v2 update docs

f3849e0

Clarify how to include several RuboCop extensions

60afe4c

Fix shared example name

5a9714e

Merge pull request #1013 from rubocop-hq/add-v2-migration-docs

38be753

Add v2 update docs

Merge pull request #1075 from rubocop-hq/refactor-top-level-group

cc09e7d

Use `case` instead of `if`

bquorning requested a review from Darhazer November 5, 2020 13:14

pirj commented Nov 5, 2020

View reviewed changes

rubocop-rspec.gemspec Show resolved Hide resolved

bquorning force-pushed the release-2.0 branch from f4b3785 to 056ee5a Compare November 5, 2020 20:26

bquorning approved these changes Nov 5, 2020

View reviewed changes

rickselby mentioned this pull request Nov 6, 2020

Bump rubocop version to 1.0 rubocop/rubocop-sequel#13

Merged

bquorning merged commit c3fa5ba into master Nov 6, 2020

bquorning deleted the release-2.0 branch November 6, 2020 16:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.0 #1055

Release 2.0 #1055

pirj commented Oct 22, 2020

bquorning commented Oct 22, 2020 •

edited

pirj commented Oct 22, 2020

bquorning commented Oct 22, 2020

bquorning commented Oct 22, 2020

pirj commented Oct 22, 2020

bquorning commented Oct 23, 2020

bquorning commented Nov 5, 2020 •

edited

pirj commented Nov 5, 2020

Darhazer commented Nov 5, 2020

pirj commented Nov 6, 2020

pirj commented Nov 6, 2020

Darhazer commented Nov 6, 2020

bquorning commented Nov 6, 2020

pirj commented Nov 6, 2020

pirj commented Nov 6, 2020

Release 2.0 #1055

Release 2.0 #1055

Conversation

pirj commented Oct 22, 2020

bquorning commented Oct 22, 2020 • edited

pirj commented Oct 22, 2020

bquorning commented Oct 22, 2020

bquorning commented Oct 22, 2020

pirj commented Oct 22, 2020

bquorning commented Oct 23, 2020

bquorning commented Nov 5, 2020 • edited

pirj commented Nov 5, 2020

Darhazer commented Nov 5, 2020

pirj commented Nov 6, 2020

pirj commented Nov 6, 2020

Darhazer commented Nov 6, 2020

bquorning commented Nov 6, 2020

pirj commented Nov 6, 2020

pirj commented Nov 6, 2020

bquorning commented Oct 22, 2020 •

edited

bquorning commented Nov 5, 2020 •

edited