New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rubocop version to 1.0 #13
Conversation
rubocop-rspec is still tied to < 1.0; this should be reinstated once v2.0 is released.
You may use |
RuboCop RSpec 2.0.0 has just been released. 🎉 |
Can we get this updated and merged? |
To be able to upgrade rubocop to 1.2.0 in our codebase, I forked and updated the gemspec manually and I don't get any errors if you need an immediate way to upgrade. Not sure if the rubocop-sequel cops are working, I haven't tested them. But the rubocop version 1.2.0 upgrade worked and all the other cops seem to be working. Take it or leave it! gem "rubocop-sequel", require: false, github: "Vydia/rubocop-sequel", ref: "56cc4c679a5077b76f551182cc04c31440e33660" |
Updated as requested. Hopefully someone from @rubocop-hq can get this merged. |
@cyberdelia I think you’re the only one who has the permissions to push the new version to https://rubygems.org/gems/rubocop-sequel 🙏 |
Is there anything more we can do to get this pushed? |
I just pushed 0.1.0: https://rubygems.org/gems/rubocop-sequel/versions/0.1.0 |
@cyberdelia You might make a few of us co-owners of the gem on RubyGems. |
I added you, @bbatsov. |
Thanks! |
Ref #12
rubocop-rspec is still tied to < 1.0; this should be reinstated once v2.0 is released. See rubocop/rubocop-rspec#1055
All the tests still pass, so I hope this will still work...!