Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop version to 1.0 #13

Merged
merged 3 commits into from Nov 11, 2020
Merged

Bump rubocop version to 1.0 #13

merged 3 commits into from Nov 11, 2020

Conversation

rickselby
Copy link
Contributor

@rickselby rickselby commented Nov 6, 2020

Ref #12

rubocop-rspec is still tied to < 1.0; this should be reinstated once v2.0 is released. See rubocop/rubocop-rspec#1055

All the tests still pass, so I hope this will still work...!

rubocop-rspec is still tied to < 1.0; this should be reinstated once v2.0 is released.
@pirj
Copy link
Member

pirj commented Nov 6, 2020

You may use rubocop-rspec 2.0.0.pre, but hopefully 2.0 will be out by Monday.

rubocop-sequel.gemspec Outdated Show resolved Hide resolved
@bquorning
Copy link
Contributor

RuboCop RSpec 2.0.0 has just been released. 🎉

@wagenet
Copy link

wagenet commented Nov 10, 2020

Can we get this updated and merged?

@TSMMark
Copy link

TSMMark commented Nov 10, 2020

To be able to upgrade rubocop to 1.2.0 in our codebase, I forked and updated the gemspec manually and I don't get any errors if you need an immediate way to upgrade.

Not sure if the rubocop-sequel cops are working, I haven't tested them. But the rubocop version 1.2.0 upgrade worked and all the other cops seem to be working.

Take it or leave it!

gem "rubocop-sequel", require: false, github: "Vydia/rubocop-sequel", ref: "56cc4c679a5077b76f551182cc04c31440e33660"

@rickselby
Copy link
Contributor Author

Updated as requested. Hopefully someone from @rubocop-hq can get this merged.

@bquorning bquorning merged commit 99fc07d into rubocop:master Nov 11, 2020
@bquorning
Copy link
Contributor

bquorning commented Nov 11, 2020

@cyberdelia I think you’re the only one who has the permissions to push the new version to https://rubygems.org/gems/rubocop-sequel 🙏

@rickselby
Copy link
Contributor Author

Is there anything more we can do to get this pushed?

@cyberdelia
Copy link
Collaborator

I just pushed 0.1.0: https://rubygems.org/gems/rubocop-sequel/versions/0.1.0
Happy to help anyone from @rubocop-hq/rubocop-core willing to automate the publication.

@bbatsov
Copy link
Contributor

bbatsov commented Nov 23, 2020

@cyberdelia You might make a few of us co-owners of the gem on RubyGems.

@cyberdelia
Copy link
Collaborator

I added you, @bbatsov.

@bbatsov
Copy link
Contributor

bbatsov commented Nov 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants