Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change department name of "nested" cops
To avoid name and department clash issues, RuboCop decided to grant each extension its own department. For those cops that already have the department matching the extension name, no changes are needed. More info rubocop/rubocop#8490 The changed cop names are: * `Capybara/CurrentPathExpectation` -> `RSpec/Capybara/CurrentPathExpectation` * `Capybara/FeatureMethods` -> `RSpec/Capybara/FeatureMethods` * `Capybara/VisibilityMatcher` -> `RSpec/Capybara/VisibilityMatcher` * `FactoryBot/AttributeDefinedStatically` -> `RSpec/FactoryBot/AttributeDefinedStatically` * `FactoryBot/CreateList` -> `RSpec/FactoryBot/CreateList` * `FactoryBot/FactoryClassName` -> `RSpec/FactoryBot/FactoryClassName` * `Rails/HttpStatus` -> `RSpec/Rails/HttpStatus`
- Loading branch information
Showing
8 changed files
with
51 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -620,54 +620,60 @@ RSpec/Yield: | |
VersionAdded: '1.32' | ||
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Yield | ||
|
||
Capybara/CurrentPathExpectation: | ||
RSpec/Capybara/CurrentPathExpectation: | ||
Description: Checks that no expectations are set on Capybara's `current_path`. | ||
Enabled: true | ||
VersionAdded: '1.18' | ||
VersionChanged: '2.0' | ||
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
bquorning
Collaborator
|
||
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation | ||
|
||
Capybara/FeatureMethods: | ||
RSpec/Capybara/FeatureMethods: | ||
Description: Checks for consistent method usage in feature specs. | ||
Enabled: true | ||
EnabledMethods: [] | ||
VersionAdded: '1.17' | ||
VersionChanged: '1.25' | ||
VersionChanged: '2.0' | ||
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/FeatureMethods | ||
|
||
Capybara/VisibilityMatcher: | ||
RSpec/Capybara/VisibilityMatcher: | ||
Description: Checks for boolean visibility in capybara finders. | ||
Enabled: true | ||
VersionAdded: '1.39' | ||
VersionChanged: '2.0' | ||
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/VisibilityMatcher | ||
|
||
FactoryBot/AttributeDefinedStatically: | ||
RSpec/FactoryBot/AttributeDefinedStatically: | ||
Description: Always declare attribute values as blocks. | ||
Enabled: true | ||
VersionAdded: '1.28' | ||
VersionChanged: '2.0' | ||
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/AttributeDefinedStatically | ||
|
||
FactoryBot/CreateList: | ||
RSpec/FactoryBot/CreateList: | ||
Description: Checks for create_list usage. | ||
Enabled: true | ||
EnforcedStyle: create_list | ||
SupportedStyles: | ||
- create_list | ||
- n_times | ||
VersionAdded: '1.25' | ||
VersionChanged: '2.0' | ||
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/CreateList | ||
|
||
FactoryBot/FactoryClassName: | ||
RSpec/FactoryBot/FactoryClassName: | ||
Description: Use string value when setting the class attribute explicitly. | ||
Enabled: true | ||
VersionAdded: '1.37' | ||
VersionChanged: '2.0' | ||
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryClassName | ||
|
||
Rails/HttpStatus: | ||
RSpec/Rails/HttpStatus: | ||
Description: Enforces use of symbolic or numeric value to describe HTTP status. | ||
Enabled: true | ||
EnforcedStyle: symbolic | ||
SupportedStyles: | ||
- numeric | ||
- symbolic | ||
VersionAdded: '1.23' | ||
VersionChanged: '2.0' | ||
This comment was marked as resolved.
Sorry, something went wrong. |
||
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.99 maybe?