New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0 #1055
Release 2.0 #1055
Commits on Oct 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5e8e32f - Browse repository at this point
Copy the full SHA 5e8e32fView commit details
Commits on Oct 22, 2020
-
Change department name of "nested" cops
To avoid name and department clash issues, RuboCop decided to grant each extension its own department. For those cops that already have the department matching the extension name, no changes are needed. More info rubocop/rubocop#8490 The changed cop names are: * `Capybara/CurrentPathExpectation` -> `RSpec/Capybara/CurrentPathExpectation` * `Capybara/FeatureMethods` -> `RSpec/Capybara/FeatureMethods` * `Capybara/VisibilityMatcher` -> `RSpec/Capybara/VisibilityMatcher` * `FactoryBot/AttributeDefinedStatically` -> `RSpec/FactoryBot/AttributeDefinedStatically` * `FactoryBot/CreateList` -> `RSpec/FactoryBot/CreateList` * `FactoryBot/FactoryClassName` -> `RSpec/FactoryBot/FactoryClassName` * `Rails/HttpStatus` -> `RSpec/Rails/HttpStatus`
3Configuration menu - View commit details
-
Copy full SHA for ccf11f7 - Browse repository at this point
Copy the full SHA ccf11f7View commit details -
Merge pull request #1019 from rubocop-hq/uber-department
Add an uber-department
Configuration menu - View commit details
-
Copy full SHA for 0f09adb - Browse repository at this point
Copy the full SHA 0f09adbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4db5ec - Browse repository at this point
Copy the full SHA e4db5ecView commit details -
Merge pull request #1054 from rubocop-hq/release
Release v2.0.0-pre, compatible with RuboCop v1.0
Configuration menu - View commit details
-
Copy full SHA for 28d7d9c - Browse repository at this point
Copy the full SHA 28d7d9cView commit details -
Only dots are used when separating versions in Rubygems.
Configuration menu - View commit details
-
Copy full SHA for ec9c8b9 - Browse repository at this point
Copy the full SHA ec9c8b9View commit details -
Why? - it was slow #925 (comment) - it ignored non-describe top-level example groups #925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - #932 - #977
Configuration menu - View commit details
-
Copy full SHA for b08c95b - Browse repository at this point
Copy the full SHA b08c95bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1af1ec2 - Browse repository at this point
Copy the full SHA 1af1ec2View commit details -
Merge pull request #968 from rubocop-hq/remove-old-cop-baseclass
Remove old Cop baseclass
Configuration menu - View commit details
-
Copy full SHA for 1b9b8a2 - Browse repository at this point
Copy the full SHA 1b9b8a2View commit details -
Merge pull request #978 from rubocop-hq/retire-top_level_describe
Retire TopLevelDescribe
Configuration menu - View commit details
-
Copy full SHA for 15aa5d3 - Browse repository at this point
Copy the full SHA 15aa5d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2d59bb - Browse repository at this point
Copy the full SHA f2d59bbView commit details -
Merge pull request #940 from rubocop-hq/reture-invalid-predicate-cop
Retire RSpec/InvalidPredicateMatcher
Configuration menu - View commit details
-
Copy full SHA for 21e4cb7 - Browse repository at this point
Copy the full SHA 21e4cb7View commit details -
This moves several files to a new `mixins/` folder. I was going to add some new macros, per [this comment][1], but thought it might clutter things up a bit to put them in the root folder. I thought of adding a `macros/` folder, but decided to emulate the [rubocop source][2] instead. [1]: #934 (comment) [2]: https://github.com/rubocop-hq/rubocop/tree/master/lib/rubocop/cop/mixin
Configuration menu - View commit details
-
Copy full SHA for 9f4d7fa - Browse repository at this point
Copy the full SHA 9f4d7faView commit details
Commits on Oct 23, 2020
-
Use config context for all cop specs
* Add shared context for all cop specs. * Remove redundant `config` metadata for cop specs. * Remove redundant `cop` subjects from cop specs.
Configuration menu - View commit details
-
Copy full SHA for 45bd976 - Browse repository at this point
Copy the full SHA 45bd976View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a6a367 - Browse repository at this point
Copy the full SHA 6a6a367View commit details -
Merge pull request #1060 from rubocop-hq/fix-documentation
Fix find_all_in_scope method docs
Configuration menu - View commit details
-
Copy full SHA for b42f401 - Browse repository at this point
Copy the full SHA b42f401View commit details -
Configuration menu - View commit details
-
Copy full SHA for 912ae66 - Browse repository at this point
Copy the full SHA 912ae66View commit details -
Merge pull request #1059 from rubocop-hq/cop-specs-config-metadata
Use config context for all cop specs
Configuration menu - View commit details
-
Copy full SHA for 5e23ee2 - Browse repository at this point
Copy the full SHA 5e23ee2View commit details
Commits on Oct 27, 2020
-
'autocorrect' shared example group does not pass a correct file name to the cop, and if this cop is tweaked to only inspect factories, this spec fails because the default file name/path is skipped, since it's not a factory path.
Configuration menu - View commit details
-
Copy full SHA for 9ea14b9 - Browse repository at this point
Copy the full SHA 9ea14b9View commit details
Commits on Oct 28, 2020
-
Merge pull request #1064 from rubocop-hq/refactor-a-spec
Refactor a spec
Configuration menu - View commit details
-
Copy full SHA for abe73f0 - Browse repository at this point
Copy the full SHA abe73f0View commit details -
lib/rubocop/cop/rspec/multiple_expectations.rb:73:32: W: Lint/ToEnumArguments: Ensure you correctly provided all the arguments. expectations_count = to_enum(:find_expectation, node).count ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ We'd still love to use OUR new cops while working on our codebase, let's see how this option works when set under RSpec namespace when we introduce the first pending cop.
Configuration menu - View commit details
-
Copy full SHA for c758ebf - Browse repository at this point
Copy the full SHA c758ebfView commit details -
Merge pull request #1065 from rubocop-hq/stop-using-edge-cops
Stop using newly added cops
Configuration menu - View commit details
-
Copy full SHA for d0588f2 - Browse repository at this point
Copy the full SHA d0588f2View commit details -
Remove relevance detection code
We have had problems with it: - it was slow - it is a non-standard extension of RuboCop's config - Include option exists - department-specific (e.g. FactoryBot) config was ignored
Configuration menu - View commit details
-
Copy full SHA for 4920879 - Browse repository at this point
Copy the full SHA 4920879View commit details
Commits on Oct 29, 2020
-
Merge pull request #1063 from rubocop-hq/remove-relevance-detection-code
Remove relevance detection code
Configuration menu - View commit details
-
Copy full SHA for 2cd7639 - Browse repository at this point
Copy the full SHA 2cd7639View commit details
Commits on Nov 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e515d21 - Browse repository at this point
Copy the full SHA e515d21View commit details -
Merge pull request #956 from sl4vr/rspec-aliases_runtime-matchers
RSpec aliases runtime matchers
Configuration menu - View commit details
-
Copy full SHA for 13cb62f - Browse repository at this point
Copy the full SHA 13cb62fView commit details -
Remove customization from RSpec/EmptyExampleGroup
The customization is now made via .rubocop.yml configuration, i.e.: RSpec: Language: Includes: Example: - it_has_special_behavior
Configuration menu - View commit details
-
Copy full SHA for 2e3ed04 - Browse repository at this point
Copy the full SHA 2e3ed04View commit details -
Merge pull request #1007 from rubocop-hq/drop-empty-example-group-cus…
…tomization Drop RSpec/EmptyExampleGroup customization
Configuration menu - View commit details
-
Copy full SHA for a434245 - Browse repository at this point
Copy the full SHA a434245View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06d6abd - Browse repository at this point
Copy the full SHA 06d6abdView commit details -
Merge pull request #1071 from rubocop-hq/enable-pending-2.0-cops
Enable pending cop(s)
Configuration menu - View commit details
-
Copy full SHA for 9a5d604 - Browse repository at this point
Copy the full SHA 9a5d604View commit details
Commits on Nov 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f3849e0 - Browse repository at this point
Copy the full SHA f3849e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60afe4c - Browse repository at this point
Copy the full SHA 60afe4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a9714e - Browse repository at this point
Copy the full SHA 5a9714eView commit details -
It reads nicer, and `flog` agrees. Before: ❯ flog lib/rubocop/cop/rspec/mixin/top_level_group.rb 29.7: flog total 5.0: flog/method average 9.8: RuboCop::Cop::RSpec::TopLevelGroup#top_level_nodes lib/rubocop/cop/rspec/mixin/top_level_group.rb:36-44 7.6: RuboCop::Cop::RSpec::TopLevelGroup#on_new_investigation lib/rubocop/cop/rspec/mixin/top_level_group.rb:10-16 4.9: RuboCop::Cop::RSpec::TopLevelGroup#top_level_groups lib/rubocop/cop/rspec/mixin/top_level_group.rb:20-22 After: ❯ flog lib/rubocop/cop/rspec/mixin/top_level_group.rb 25.8: flog total 4.3: flog/method average 7.2: RuboCop::Cop::RSpec::TopLevelGroup#top_level_nodes lib/rubocop/cop/rspec/mixin/top_level_group.rb:35-44 6.3: RuboCop::Cop::RSpec::TopLevelGroup#on_new_investigation lib/rubocop/cop/rspec/mixin/top_level_group.rb:10-15 4.9: RuboCop::Cop::RSpec::TopLevelGroup#top_level_groups lib/rubocop/cop/rspec/mixin/top_level_group.rb:19-21
Configuration menu - View commit details
-
Copy full SHA for c61929a - Browse repository at this point
Copy the full SHA c61929aView commit details -
Merge pull request #1013 from rubocop-hq/add-v2-migration-docs
Add v2 update docs
Configuration menu - View commit details
-
Copy full SHA for 38be753 - Browse repository at this point
Copy the full SHA 38be753View commit details -
Merge pull request #1075 from rubocop-hq/refactor-top-level-group
Use `case` instead of `if`
Configuration menu - View commit details
-
Copy full SHA for cc09e7d - Browse repository at this point
Copy the full SHA cc09e7dView commit details -
- Add explicit dependency on rubocop-ast >= 1.1.0. - Rename the "Change log" to "Changelog". - Remove mention of "potentially breaking" changes. All changes between 1.x and 2.0 should be regarded as potentially breaking, so no need to highlight one over the rest. - Link to the upgrade document from README.
Configuration menu - View commit details
-
Copy full SHA for 056ee5a - Browse repository at this point
Copy the full SHA 056ee5aView commit details