http3: change code point for HTTP datagrams to RFC 9297 #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm hesitant to merge this PR. First of all, we don't actually support this RFC. We support QUIC DATAGRAMs, but not HTTP/3 DATAGRAMs. Second, Chrome's WebTransport implementation does some datagram support detection (not sure if QUIC or H3), and refuses to establish a WebTransport connection if datagrams are disabled, so we'd have to be extra careful not to break things there. |
|
Capsule support has been merged in #3607, just adding it here for context. |
|
@kokes Sorry for the long delay. Can you please rebase? |
|
Rebased. |
marten-seemann
changed the title
marten-seemann
changed the title
marten-seemann
approved these changes
Aug 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #3588 +/- ##
==========================================
+ Coverage 82.80% 82.84% +0.04%
==========================================
Files 147 147
Lines 14758 14758
==========================================
+ Hits 12220 12226 +6
+ Misses 2036 2031 -5
+ Partials 502 501 -1
|
dongcarl
approved these changes
Aug 8, 2023
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Aug 23, 2023
Our WASM Webtransport interoperability tests previously used Chrome 112. This Chrome version fails to connect to go-libp2p with quic-go v0.38.0. See libp2p/go-libp2p#2506 for failure. This is due to quic-go v0.38.0 moving to the updated code point for HTTP datagrams. See quic-go/quic-go#3588 for details. This commit upgrades our interop tests to use Chrome 115.
4 tasks
mergify bot
pushed a commit
to libp2p/rust-libp2p
that referenced
this pull request
Aug 23, 2023
Our WASM Webtransport interoperability tests previously used Chrome 112. This Chrome version fails to connect to go-libp2p with quic-go v0.38.0. See libp2p/go-libp2p#2506 for failure. This is due to quic-go v0.38.0 moving to the updated code point for HTTP datagrams. See quic-go/quic-go#3588 for details. This commit upgrades our interop tests to use Chrome 115. Pull-Request: #4383.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few references to HTTP/3 Datagrams that seem to be out of date. The referred doc has been superseeded by RFC 9297, so I updated the links and changed a few error/frame type values that have changed since the draft (see the draft where it says "note that this will switch to a lower value before publication").
I have not updated the README to say quic-go supports RFC 9297 as I don't know if it's the case, especially since I don't see any references to Quarter Stream IDs for instance.