Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new value for SETTINGS_H3_DATAGRAM (according to RFC9297) #4006

Closed
wants to merge 1 commit into from

Conversation

Tantalor93
Copy link

@Tantalor93 Tantalor93 commented Jul 31, 2023

Hello, while using the quic-go library I noticed that according to the RFC9297 the correct value for settingsDatagram is 0x33 (also mentioned here), the value 0xffd277 was used in draft. I gave it a shot and tried to fix it myself, let me know if I am missing something 馃檪. Otherwise thanks for the great work on this project!

RFC9297

An endpoint can indicate to its peer that it is willing to receive HTTP/3 Datagrams by sending the SETTINGS_H3_DATAGRAM (0x33) setting with a value of 1.

old draft IANA consideration:

HTTP/3 SETTINGS Parameter
This document will request IANA to register the following entry in the "HTTP/3 Settings" registry:
Value:
0xffd277 (note that this will switch to a lower value before publication)
Setting Name:
H3_DATAGRAM

@google-cla
Copy link

google-cla bot commented Jul 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@marten-seemann
Copy link
Member

We'll need to test if this breaks WebTransport support with Chrome and Firefox.

@dongcarl
Copy link

Just for reference, the new standardized value has been part of the web-platform-tests suite since 3 months ago: web-platform-tests/wpt#39201.

@marten-seemann
Copy link
Member

Duplicate of #3588.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants