Skip to content

Commit

Permalink
http3: change code point for HTTP datagrams to RFC 9297 (#3588)
Browse files Browse the repository at this point in the history
* HTTP/3 Datagrams are now RFC 9297

* Use datatracker htmlized docs rather than rfc-editor (to be consistent)
  • Loading branch information
kokes committed Aug 9, 2023
1 parent 10d1114 commit 05db808
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion http3/error_codes.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const (
ErrCodeMessageError ErrCode = 0x10e
ErrCodeConnectError ErrCode = 0x10f
ErrCodeVersionFallback ErrCode = 0x110
ErrCodeDatagramError ErrCode = 0x4a1268
ErrCodeDatagramError ErrCode = 0x33
)

func (e ErrCode) String() string {
Expand Down
2 changes: 1 addition & 1 deletion http3/frames.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (f *headersFrame) Append(b []byte) []byte {
return quicvarint.Append(b, f.Length)
}

const settingDatagram = 0xffd277
const settingDatagram = 0x33

type settingsFrame struct {
Datagram bool
Expand Down
2 changes: 1 addition & 1 deletion http3/roundtrip.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ type RoundTripper struct {

// Enable support for HTTP/3 datagrams.
// If set to true, QuicConfig.EnableDatagram will be set.
// See https://www.ietf.org/archive/id/draft-schinazi-masque-h3-datagram-02.html.
// See https://datatracker.ietf.org/doc/html/rfc9297.
EnableDatagrams bool

// Additional HTTP/3 settings.
Expand Down
2 changes: 1 addition & 1 deletion http3/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ type Server struct {

// EnableDatagrams enables support for HTTP/3 datagrams.
// If set to true, QuicConfig.EnableDatagram will be set.
// See https://datatracker.ietf.org/doc/html/draft-ietf-masque-h3-datagram-07.
// See https://datatracker.ietf.org/doc/html/rfc9297.
EnableDatagrams bool

// MaxHeaderBytes controls the maximum number of bytes the server will
Expand Down

0 comments on commit 05db808

Please sign in to comment.