fix(interop/WASM): use selenium/standalone-chrome:115.0 #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our WASM Webtransport interoperability tests previously used Chrome 112. This Chrome version fails to connect to go-libp2p with quic-go v0.38.0. See libp2p/go-libp2p#2506 for failure. This is due to quic-go v0.38.0 moving to the updated code point for HTTP datagrams. See quic-go/quic-go#3588 for details. This commit upgrades our interop tests to use Chrome 115.
mxinden
added
send-it
trivial
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
@mergify backport v0.52 |
❌ No backport have been created
GitHub error: |
mxinden
changed the title
Makes total sense, given that current |
mxinden
added a commit
to libp2p/test-plans
that referenced
this pull request
Aug 23, 2023
Bump rust-libp2p v0.52 interop version to include libp2p/rust-libp2p#4383 which fixes issue in libp2p/go-libp2p#2506.
mxinden
added a commit
to libp2p/test-plans
that referenced
this pull request
Aug 24, 2023
Bump rust-libp2p v0.52 interop version to include libp2p/rust-libp2p#4383 which fixes issue in libp2p/go-libp2p#2506.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our WASM Webtransport interoperability tests previously used Chrome 112. This Chrome version fails to connect to go-libp2p with quic-go v0.38.0. See libp2p/go-libp2p#2506 for failure. This is due to quic-go v0.38.0 moving to the updated code point for HTTP datagrams. See quic-go/quic-go#3588 for details.
This commit upgrades our interop tests to use Chrome 115.
Notes & open questions
Change checklist