Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: Compare strings to a null string directly #168

Closed
wants to merge 1 commit into from
Closed

Optimization: Compare strings to a null string directly #168

wants to merge 1 commit into from

Conversation

johnsonjh
Copy link

@johnsonjh johnsonjh commented Nov 4, 2020

  • Small run-time optimization

@johnsonjh johnsonjh changed the title Optimization: Compare string to null string direct Optimization: Compare strings to a null string directly Nov 4, 2020
@cjdelisle
Copy link
Member

conflicts, not worth my time to fix, shouldn't really be worth your time either

@johnsonjh
Copy link
Author

Not really any of my time at all, I believe these were automatically applied by some linter/checker or another. I normally run all the sources through a small battery of them, so, no real time of mine inovlved - leave open for now, and if it picks it up again, I'll submit rebased - but yeah, if I have to do it manually, it's such a small optimization that I won't bother.

@johnsonjh
Copy link
Author

@cjdelisle autorebased

@johnsonjh
Copy link
Author

johnsonjh commented Nov 26, 2020

Auto-merging config.go
Merge made by the 'recursive' strategy.
 cmd/pktctl/pktctl.go           | 2 +-
 config.go                      | 2 +-
 integration/rpctest/btcd.go    | 2 +-
 neutrino/cache/lru/lru_test.go | 2 +-
 neutrino/query_test.go         | 2 +-
 pktconfig/version/version.go   | 2 +-
 txscript/reference_test.go     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

@johnsonjh
Copy link
Author

  • NOTE: Applied to WIP rebase branch successfully.

@johnsonjh johnsonjh closed this Dec 28, 2020
@johnsonjh johnsonjh deleted the no-extra-lens branch December 28, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants