Remove TTY detection

[johnsonjh]

• More reliable TTY detection

[johnsonjh]

The build failure is a Travis false positive, and fixed in #222

[cjdelisle]

I'd rather just delete the logic here, who cares if you log to a file when doing a --create

[johnsonjh]

f978c47 apparently you cared! Haha.

I'd be fine with getting rid of it, I don't think anything we have relies on the behavior... the intention was probably to avoid inadvertently writing the seed out to disk?

[johnsonjh]

@cjdelisle Pushed a replacement that just deletes the logic, if you prefer that.

[johnsonjh]

• Verified clean merge with recursive strategy against develop as of Thu Nov 26 02:01:32 PM EST 2020 + PR Improvement in bbolt/walletdb speed #111 + PR More reliably detect if we are current (or not.) #142 + PR Fix bug where pktctl -h would show help twice. #151 + PR blockchain: Avoid deadlock with additional locking #156 + PR peer: Default to 1s default trickle interval #160 + PR Optimization: Compare strings to a null string directly #168 + PR Fix cookie authentication; always show version information #175 + PR btcutil/hdkeychain/extendedkey.go: Fix a typo. #185

Merge made by the 'recursive' strategy.
 pktwallet/config.go | 5 -----
 1 file changed, 5 deletions(-)

[johnsonjh]

@cjd per private discussion, not using https://github.com/mattn/go-isatty - we'll just remove this check for now - https://github.com/mattn/go-isatty is a great solution, however, if you need this sort of check to be reliable.

On Windows, you have the "legacy terminal" (ala CMD or NTVDM), Windows Terminal, Cygwin Cygpty, MinGW Term, Git Bash Term, mintty, MobaXterm (Cygpty-compatible, mostly), PowerShell (launched 'alone') (vs PowerShell 7 which behaves different from the others in some ways), and PowerShell ISE (which is also different), etc... it's stupidworld over in Windows-land! I'm super-aware of just how bad it is, now that I have Windows on the test VM and setup for CI/CD.

I assume they never change or remove the old interfaces to not break older products - but it means that sometimes you need do "winpty pktwallet" and maybe Get-Content to get the result you want depending on what sort of terminal you're in and what sort of redirection or logging you want.

Example: Using PowerShell, a simple SOMEPROG < SOMEFILE that works in the legacy terminal (CMD) is NOT going to work if SOMEPROG is a "legacy" console program, you'll need to do Get-Content SOMEFILE | SOMEPROG instead. Now, if you are already in a Cygwin/MSYS-enabled console (like mintty), then running a PowerShell there, you need to do Get-Content SOMEFILE | winpty SOMEPROG. And it gets worse and worse and totally depends on the combination of the programs and your current terminal.

Happy to avoid the whole situation.

[johnsonjh]

• NOTE: Applied to WIP rebase branch successfully.