Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed the RNG w/CSPRNG for higher quality cookies #239

Closed
wants to merge 1 commit into from
Closed

Seed the RNG w/CSPRNG for higher quality cookies #239

wants to merge 1 commit into from

Conversation

johnsonjh
Copy link

@johnsonjh johnsonjh commented Nov 26, 2020

  • Crypto-nerd pedantic change as cookie file is written with restrictive permissions, but standard Golang math/rand implementation is rather crap and any overhead from additional RNG seeding once per pktd start-up is so low enough to be essentially immeasurable across 150k runs.
  • Edit: Verified (default) Golang runtime entropy retrieval on all our supported platforms is non-blocking, so no risk of causing any start-up time regressions in virtualized environments or when system entropy pool is near-exhausted.

@johnsonjh
Copy link
Author

Auto-merging config.go
Merge made by the 'recursive' strategy.
 config.go | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

@johnsonjh
Copy link
Author

Newly rebased PR #235 successfully verified against develop + #236 + #237 + #238 + #239 and base develop.

@johnsonjh
Copy link
Author

  • NOTE: Applied to WIP rebase branch successfully.

@johnsonjh johnsonjh closed this Dec 28, 2020
@johnsonjh johnsonjh deleted the extrarandom branch December 28, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant