Relabel: relabel links instead of their targets #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrayst
requested review from
kolyshkin,
mrunalp,
rhatdan,
runcom and
thaJeztah
as code owners
|
LGTM |
|
@rrayst could you perhaps amend the commit message to describe what's being fixed (so that git log itself provides those details, not having to resort to GitHub)? I see you wrote some bits in the related ticket that could be used for that; #172 (comment) (FWIW, It's ok to remove the |
Signed-off-by: Tobias Polley <polley@predic8.de>
|
@thaJeztah PTAL |
thaJeztah
approved these changes
Mar 21, 2022
This was referenced Mar 31, 2022
flouthoc
added a commit
to flouthoc/buildah
that referenced
this pull request
Apr 1, 2022
lsetxattr always fails with ENOTSUP when it tries to relabel /proc/self/fd/%d but in this case we are acutally intrested on the actual file pointed by the `/proc/self/fd/%d` not in the `symlink` so use `Chcon` instead of `Relabel` since `Relabel` was configured here opencontainers/selinux#173 to use `lsetxattr` instead of `setxattr`. [ NO NEW TESTS NEEDED ] [ NO TEST NEEDED ] Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
added a commit
to flouthoc/buildah
that referenced
this pull request
Apr 1, 2022
lsetxattr always fails with ENOTSUP when it tries to relabel /proc/self/fd/%d but in this case we are acutally intrested on the actual file pointed by the `/proc/self/fd/%d` not in the `symlink` so use `Chcon` instead of `Relabel` since `Relabel` was configured here opencontainers/selinux#173 to use `lsetxattr` instead of `setxattr`. [NO NEW TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tobias Polley polley@predic8.de