Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Buildah v1.25.1, openshift/imagebuilder v1.2.3 #13726

Conversation

TomSweeneyRedHat
Copy link
Member

[NO NEW TESTS NEEDED]

This bumps Buildah to v1.25.1 and openshift/imagebuilder to v1.2.3

Signed-off-by: tomsweeneyredhat tsweeney@redhat.com

[NO NEW TESTS NEEDED]

This bumps Buildah to v1.25.1 and openshift/imagebuilder to v1.2.3

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@TomSweeneyRedHat
Copy link
Member Author

I'm leery about adding the "replace" command for containers/common, but for the moment, it's the quickest way around a nasty vendor dance that we're undergoing. We should talk at standup tomorrow about the state of the c/common main branch and plans for the near future for it and the other branches. It's not clear to me at least.

@Luap99 @vrothberg PTAL

@edsantiago
Copy link
Collaborator

This is badly, badly broken. Common factor, best I can tell, is:

# podman build SOMETHING
STEP 1 FROM ... <----- is ok
STEP 2 RUN some command     <---- this is what fails
error running container: setting file label on "/proc/self/fd/12": lsetxattr /proc/self/fd/12: operation not supported

@TomSweeneyRedHat
Copy link
Member Author

The problem seems to be pulling in this commit from c/common containers/common#971 and then the changes in Podman to use that. I tried to back that out of Podman temporarily, but I'm too tired to see straight at this point. @Luap99 or @vrothberg if you could take a look when you get in, I'd appreciate it.

github.com/opencontainers/go-digest v1.0.0
github.com/opencontainers/image-spec v1.0.3-0.20220114050600-8b9d41f48198
github.com/opencontainers/runc v1.1.0
github.com/opencontainers/runtime-spec v1.0.3-0.20211214071223-8958f93039ab
github.com/opencontainers/runtime-tools v0.9.1-0.20220110225228-7e2d60f1e41f
github.com/opencontainers/selinux v1.10.0
github.com/opencontainers/selinux v1.10.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to remove this change to fix the tests, see #13687 containers/buildah#3875

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Luap99 I think we might wanna revert version bump of selinux in c/common cause make vendor will automatically bump selinux. Could you review my above PR.

@flouthoc
Copy link
Collaborator

@TomSweeneyRedHat I think you can do go mod edit -replace github.com/opencontainers/selinux=github.com/opencontainers/selinux@v1.10.0 till this is fixed or reverted in c/common

@TomSweeneyRedHat
Copy link
Member Author

Closing, replaced by #13733

@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/bumpbuildah branch May 27, 2022 14:27
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants