Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selinux: revert to v1.10.0 #994

Closed
wants to merge 1 commit into from
Closed

Conversation

flouthoc
Copy link
Collaborator

Reverts #987

I think new version of selinux is doing a blank replace of setxattr with lsetxattr where some of the context for lsetxattr throws ENOTSUP this is causing regression in containers/podman#13726

Buildah and other parts must be instrumented to either ignore ENOTSUP or look for an alternative before bumping selinux.

Signed-off-by: Aditya R <arajan@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flouthoc
To complete the pull request process, please assign rhatdan after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhatdan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2022

We can just change the version in podmans go.mod, there is no need to revert it here.

@flouthoc
Copy link
Collaborator Author

I think make vendor automatically bumps the version which is being used by dependency even if you manually change it.
Even though i think c/common should point to the last working version until buildah accepts new version of selinux.

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2022

Yeah we might have to use replace.

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2022

Or we just use the c/common commit before #987

@flouthoc
Copy link
Collaborator Author

It could be issue in this upstream itself opencontainers/selinux#173 but not sure.

@rhatdan
Copy link
Member

rhatdan commented Mar 31, 2022

NO SELinux is correct the issue is in Buildah. ENOSUP might need to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants