Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump opencontainers/selinux from 1.10.0 to 1.10.1 #6865

Merged
merged 1 commit into from Apr 27, 2022
Merged

Bump opencontainers/selinux from 1.10.0 to 1.10.1 #6865

merged 1 commit into from Apr 27, 2022

Conversation

log1cb0mb
Copy link
Contributor

@log1cb0mb log1cb0mb commented Apr 27, 2022 •
edited

Full Changelog:
opencontainers/selinux@v1.10.0...v1.10.1

Specifically patch opencontainers/selinux#173 which fixes the issue: #6767

Signed-off-by: Nabeel Rana nabeelnrana@gmail.com

@k8s-ci-robot
Copy link

Hi @log1cb0mb. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@log1cb0mb log1cb0mb changed the title Bump github.com/opencontainers/selinux from 1.10.0 to 1.10.1 Bump opencontainers/selinux from 1.10.0 to 1.10.1 Apr 27, 2022
@log1cb0mb log1cb0mb force-pushed the bump-opencontainers/selinux-to-v1.10.1 branch from 1c33923 to db7eab5 Compare April 27, 2022 18:15
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2022

Build succeeded.

@dmcgowan
Copy link
Member

Signed-off-by: log1cb0mb nabeelnrana@gmail.com

Please sign the commit using real name rather than username (https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work)

@dmcgowan dmcgowan added this to New in Code Review via automation Apr 27, 2022
@dmcgowan dmcgowan moved this from New to Needs Contributor Update in Code Review Apr 27, 2022
@log1cb0mb log1cb0mb force-pushed the bump-opencontainers/selinux-to-v1.10.1 branch from db7eab5 to f170937 Compare April 27, 2022 19:14
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2022

Build succeeded.

@thaJeztah
Copy link
Member

Looks like you may have to run go mod tidy from within the integration/client directory as well (which also has a go.mod);

Files /home/runner/work/containerd/containerd/src/github.com/containerd/containerd/integration/client/go.mod and /tmp/tmp.PYcoKntieN/containerd/integration/client/go.mod differ
Files /home/runner/work/containerd/containerd/src/github.com/containerd/containerd/integration/client/go.sum and /tmp/tmp.PYcoKntieN/containerd/integration/client/go.sum differ

@thaJeztah thaJeztah added the cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch label Apr 27, 2022
@log1cb0mb
Bump opencontainers/selinux from 1.10.0 to 1.10.1
ae29594 
Signed-off-by: Nabeel Rana <nabeelnrana@gmail.com>
@log1cb0mb log1cb0mb force-pushed the bump-opencontainers/selinux-to-v1.10.1 branch from f170937 to ae29594 Compare April 27, 2022 19:55
thaJeztah
thaJeztah approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

/ok-to-test

estesp
estesp approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2022

Build succeeded.

@log1cb0mb log1cb0mb mentioned this pull request Apr 27, 2022
Closed
@kzys kzys merged commit cb84b5a into containerd:main Apr 27, 2022
Code Review automation moved this from Needs Contributor Update to Done Apr 27, 2022
@log1cb0mb log1cb0mb mentioned this pull request Apr 28, 2022
Closed
@thaJeztah thaJeztah mentioned this pull request Apr 29, 2022
Merged
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch labels Apr 29, 2022
@thaJeztah thaJeztah mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch ok-to-test
Projects
Code Review
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@log1cb0mb @k8s-ci-robot @dmcgowan @thaJeztah @kzys @estesp