Bottom left "action" (gear icon) menu not scrolling (MacOS)

[atrn]

• VSCode Version: Code 1.19.0 (816be67, 2017-12-14T09:51:12.123Z)
• OS Version: Darwin x64 16.7.0
• Extensions:

Extension	Author (truncated)	Version
vscode-markdownlint	Dav	0.12.0
project-manager	ale	0.23.1
alignment	ann	0.3.0
code-gnu-global	aus	0.2.2
togglehs	bbe	0.1.2
gitignore	cod	0.5.0
githistory	don	0.2.3
git-project-manager	fel	1.4.0
auto-close-tag	for	0.5.5
Go	luk	0.6.69
vscode-clang	mit	0.2.2
cpptools	ms-	0.14.4
debugger-for-chrome	msj	4.0.0
vscode-emacs-improved	rkw	0.1.1
cmake	twx	0.0.17
vscode-lldb	vad	0.7.1
cmake-tools	vec	0.10.3
gitblame	wad	2.2.0
clang-format	xav	1.6.1

(7 theme extensions excluded)

---

Steps to Reproduce:

1. Resize VS Code window so it occupies most but not all, of the display.
2. Click on bottom left "action" (gear icon) menu because it has
   an indicator on it (I'd just updated and it was the restart button).
3. Menu draws as a drop down but is clipped due to lack of space. See arrow at bottom of menu indicating it can scroll.
4. Attempt to scroll menu clicking on arrow and usual MacOS pointer motion. Menu doesn't scroll.
5. Resize window to give more room below (effectively moving the gear icon up a little). Click gear icon and see full menu.

The menu display changes location at different window sizes, which really means available space for the menu's height. With a slightly larger window size the menu renders itself above and to the right of the gear icon. Reducing the window height a little has it render as a drop-down (below) but with insufficient height to display the full menu and adds the non-functioning scroll arrow.

Reproduces without extensions: Yes

[ricobbe]

After the most recent VSCode update, the gear-icon menu mentioned in the original submission appears to be fixed; it now displays on-screen in a position that allows the entire menu to display without scrolling.

However, I can still reproduce the original problem by right-clicking on an identifier in a line of an editor window that's close to the bottom of the screen. See attached screenshot for an example; the bottom of the screenshot is the bottom of the screen. As in the original report, neither clicking on nor hovering over the downward arrow in the popup menu has any effect.

[bpasero]

This bugs me a lot too, @deepak1556 any clues?

[bpasero]

This is annoying. @deepak1556 we should address this somehow.

[bpasero]

This is reported as electron/electron#14261

[akaroml]

Here's a related case in the bottom left corner. When there is enough space (full screen available) to show the full menu, vscode only uses a smaller portion and shows part of the menu items. I need to scroll to see all the items all the time. Check out this screen recording:

[bpasero]

@deepak1556 @sbatten latest insiders from today seems to have fixed the issue for me! did we also move the location of the menu in native? I know we changed it for the custom menu.

[sbatten]

well i did change the native one to use the mouse location instead, but I'm not understanding the position in your screen shot.

[sbatten]

oh I know, what's happening (I used native for titlebar setting but forgot macos titlebar custom => native menus) so its using the custom menu logic. I mean I can keep it that way if it looks good?

[bpasero]

@sbatten since it is not a right-click menu I think the position now is actually better than before and if it fixes the scrolling issue on macOS, even better.

[sbatten]

since the fix was caused by a bug in the logic, i updated the logic to make it intentional. will close this now

[sbatten]

I updated how context view lays making alignment a lot better for custom menus. Unfortunately we don't have that level of control for native menus. The "bug" that fixed this has been removed since it is not a reliable fix and it resulted in some strange cases as well.

[deepak1556]

Is this still an issue ? I am unable to repro with latest insiders.

[atrn]

Seems to have been fixed for a while. Works fine for me these days.

[bpasero]

This is happening for a long time still:

Refs: electron/electron#13279

[bpasero]

Looks like a fix is in the works: electron/electron#35194

[bpasero]

Nice 🎸