-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Electron 19 #154092
chore: update to Electron 19 #154092
Conversation
594ef48
to
a36f047
Compare
a36f047
to
fd615ed
Compare
This makes vscode work under asahi linux(running on macs with m1 processors) since the asahi linux kernel uses 16kb pagesize which causes electron before v19 to crash with segmentation fault. Regards |
@moham96 the fix is already available in VSCode stable |
well, i tried using the aur version of visual-studio-code which pulls the 1.69.1 version but it still gives me segmentation fault, compiling the |
Fixes #153849 |
You should bump to 19.0.10 which includes the |
19.0.10 fixes electron/electron#33578 too. |
Looks like the libgcc dependency changed |
Should @rzhao271 review the other changes? |
My 👍 still stands, leaving new changes for Raymond. |
Fixes #154693
Fixes #154705
Fixes #153849
Fixes #150779
Fixes #40262
Fixes #150475