Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Electron 19 #154092

Merged
merged 24 commits into from
Aug 4, 2022
Merged

chore: update to Electron 19 #154092

merged 24 commits into from
Aug 4, 2022

Conversation

deepak1556
Copy link
Contributor

@deepak1556 deepak1556 commented Jul 4, 2022

  • Nightly exploration builds

Fixes #154693
Fixes #154705
Fixes #153849
Fixes #150779
Fixes #40262
Fixes #150475

@deepak1556 deepak1556 self-assigned this Jul 4, 2022
@deepak1556 deepak1556 added this to the July 2022 milestone Jul 4, 2022
@deepak1556 deepak1556 changed the title chore: bump electron@19.0.7 chore: update to Electron 19 Jul 4, 2022
@deepak1556 deepak1556 force-pushed the electron-19.x.y branch 2 times, most recently from 594ef48 to a36f047 Compare July 6, 2022 09:23
@moham96
Copy link

moham96 commented Jul 14, 2022

This makes vscode work under asahi linux(running on macs with m1 processors) since the asahi linux kernel uses 16kb pagesize which causes electron before v19 to crash with segmentation fault.
I hope this gets pulled into main stable branch as soon as possible.

Regards

@deepak1556
Copy link
Contributor Author

@moham96 the fix is already available in VSCode stable 1.69 as part of Electron 18 update, you can refer to #145527 (comment) for context.

@moham96
Copy link

moham96 commented Jul 14, 2022

@moham96 the fix is already available in VSCode stable 1.69 as part of Electron 18 update, you can refer to #145527 (comment) for context.

well, i tried using the aur version of visual-studio-code which pulls the 1.69.1 version but it still gives me segmentation fault, compiling the electron-19.x.y branch doesn't result in a segmentation fault

@deepak1556 deepak1556 modified the milestones: July 2022, August 2022 Jul 25, 2022
@deepak1556 deepak1556 mentioned this pull request Jul 26, 2022
3 tasks
@ayr-ton
Copy link

ayr-ton commented Jul 28, 2022

Fixes #153849

@ReillyBrogan
Copy link

You should bump to 19.0.10 which includes the --ozone-platform-hint=auto flag, useful for those who want to switch between Wayland and X11 backends automatically on Linux.

@Austaras
Copy link

19.0.10 fixes electron/electron#33578 too.

@deepak1556 deepak1556 marked this pull request as ready for review July 30, 2022 02:38
@rzhao271
Copy link
Contributor

rzhao271 commented Aug 1, 2022

Looks like the libgcc dependency changed

@bpasero
Copy link
Member

bpasero commented Aug 2, 2022

Should @rzhao271 review the other changes?

@bpasero bpasero requested review from rzhao271 and removed request for bpasero August 2, 2022 05:33
@bpasero
Copy link
Member

bpasero commented Aug 2, 2022

My 👍 still stands, leaving new changes for Raymond.

rzhao271
rzhao271 previously approved these changes Aug 4, 2022
@deepak1556 deepak1556 merged commit c47ed87 into main Aug 4, 2022
@deepak1556 deepak1556 deleted the electron-19.x.y branch August 4, 2022 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.