Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected status bar context menu #108308

Closed
jrieken opened this issue Oct 8, 2020 · 8 comments
Closed

Unexpected status bar context menu #108308

jrieken opened this issue Oct 8, 2020 · 8 comments
Assignees
Labels
*as-designed Described behavior is as designed under-discussion Issue is under discussion for relevance, priority, approach workbench-status Status bar

Comments

@jrieken
Copy link
Member

jrieken commented Oct 8, 2020

See attached screen capture, the groups is confusing and I often select the wrong item because the primary/top item is hide status bar, not hide for the entry. Context menus for the activity bar get this right

馃槙

Screenshot 2020-10-08 at 15 13 15

馃槃

Screenshot 2020-10-08 at 15 14 33

@bpasero bpasero added the under-discussion Issue is under discussion for relevance, priority, approach label Oct 10, 2020
@bpasero
Copy link
Member

bpasero commented Oct 10, 2020

This is actually intentional with the rationale that it makes hiding an entry from the status bar fast because you do not have to move your mouse all the way up.

//cc @misolori

@miguelsolorio
Copy link
Contributor

I think one of the things that really bother me is how the context menu starts from your cursor and downwards in the status bar, so you actually end up having to move your cursor all the way down:

image

We should make all of these consistent, panels + views also behave the same as the activity bar:

image

image

@bpasero
Copy link
Member

bpasero commented Oct 13, 2020

@misolori the status bar is typically to the bottom of the screen since the window is likely maximized and then the menu opens to the top:

image

The rationale was that in order to hide the entry you right click, you should not move the mouse all the way up. As such the "Hide" entry appears first.

Should we change it? Doesn't this break muscle memory and people will start to hide the status bar always?

@bpasero bpasero added the workbench-status Status bar label Oct 13, 2020
@bpasero
Copy link
Member

bpasero commented Oct 14, 2020

A very similar thing we do is to put most recent folders/workspaces to the bottom of the dock context menu:

image

@miguelsolorio
Copy link
Contributor

Ah, ok so I think what I've always seen is a bug on mac where the menu does not start at the bottom, so for me I've always had to scroll a lot:

If we're able to get the menu to work consistently then I think having the "hide this" menu option as the first thing makes sense. But I'm also fine making all menus the same.

@bpasero
Copy link
Member

bpasero commented Oct 16, 2020

I will call my veto here on changing it as UX owner of the experience. Especially in codespaces for example, I see tons of entries and having a fast way to hide exactly the one you right click is crucial to me:

image

@bpasero bpasero added the *as-designed Described behavior is as designed label Oct 16, 2020
@bpasero
Copy link
Member

bpasero commented Oct 16, 2020

@misolori the fact that the menu scrolls is actually a bug we never figured out how to resolve in electron. See #40262

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed under-discussion Issue is under discussion for relevance, priority, approach workbench-status Status bar
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @jrieken @miguelsolorio and others