Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus: Dropdown menu gets tiny when opened near the edge of the workbench #102409

Closed
bravecobra opened this issue Jul 13, 2020 · 6 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release menus Menu items and widget issues verified Verification succeeded

Comments

@bravecobra
Copy link

  • VSCode Version: 1.47
  • OS Version: All

Steps to Reproduce:

Just add a lot of repositories
image

The submenu should open to the top instead of always to the bottom when opened in the lower part of the screen. This view is just become unusable.
Is there a way to revert to the previous behaviour? I can't say I'm happy with this new view. With lots of repositories this is not an improvement, on the contrary.

Does this issue occur when all extensions are disabled?: Yes

@sbatten
Copy link
Member

sbatten commented Jul 13, 2020

@bravecobra sorry for this. 2 workarounds: the first would be to move the view up toward the top so the menu doesn't try to open like this. the second workaround which even less ideal is to use the native title bar experience. window.titleBarStyle. This uses more native menus which don't have this bug but affects the title bar and menu bar styling as well.

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues labels Jul 13, 2020
@sbatten sbatten added this to the July 2020 milestone Jul 13, 2020
@sbatten
Copy link
Member

sbatten commented Jul 13, 2020

fyi @joaomoreno

@joaomoreno joaomoreno changed the title Unified Source control view submenu is not usable with lot of repositories Menus: Dropdown menu gets tiny when opened near the edge of the workbench Jul 13, 2020
@joaomoreno
Copy link
Member

Here's where the SCM single view feedback is being collected: #102118

@sbatten
Copy link
Member

sbatten commented Jul 14, 2020

the menus try to shrink if they think there isn't enough room. normally a menu is drawn in the top left of the window before being positioned, but now dropdowns are using the anchor as the parent of the menu. this means we need to set the position of the container to fixed before rendering the menu to give it enough space to avoid shrinking more than necessary.

Charles-Gagnon pushed a commit to Charles-Gagnon/vscode that referenced this issue Jul 14, 2020
@sbatten sbatten added the candidate Issue identified as probable candidate for fixing in the next release label Jul 15, 2020
@sbatten sbatten reopened this Jul 15, 2020
sbatten added a commit to sbatten/vscode that referenced this issue Jul 15, 2020
sbatten added a commit that referenced this issue Jul 15, 2020
@sbatten sbatten closed this as completed Jul 15, 2020
@eamodio eamodio added the verified Verification succeeded label Jul 15, 2020
@ryenus
Copy link
Contributor

ryenus commented Jul 20, 2020

It seems the problem still exists with 1.47.2

What's happening:
image

What's expected:
image

@sbatten
Copy link
Member

sbatten commented Jul 20, 2020

@ryenus that is a separate macOS + electron issue. #40262

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@joaomoreno @bravecobra @ryenus @eamodio @sbatten and others