Move meteorBabelHelpers to modules package, and restrict to legacy bundle. #10596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndle. Should fix #10595. Code from the application `node_modules` directory becomes part of the `modules` package, so that it can be imported by any other package that uses the module system, regardless of package load order. Now that we compile code from `node_modules` using `babel-compiler` and `meteor-babel` (#10585), `node_modules` code requires the same runtime environment as any other Meteor JS code. For the most part, this need is satisfied by the `@babel/runtime/helpers/...` modules, which are also defined in the `modules` package because they come from `node_modules`. However, in the legacy bundle, `meteorBabelHelpers.sanitizeForInObject` is used to fix buggy for-in iteration in older Internet Explorers. Thankfully, this extra helper code does not need to be included in the modern or server bundles, but only in legacy code.
|
By the way, I submitted this as a PR rather than just pushing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #10595.
Code from the application
node_modulesdirectory becomes part of themodulespackage, so that it can be imported by any other package that uses the module system, regardless of package load order.Now that we compile code from
node_modulesusingbabel-compilerandmeteor-babel(#10585),node_modulescode requires the same runtime environment as any other Meteor JS code. For the most part, this need is satisfied by the@babel/runtime/helpers/...modules, which are also defined in themodulespackage because they come fromnode_modules. However, in the legacy bundle,meteorBabelHelpers.sanitizeForInObjectis used to fix buggy for-in iteration in older Internet Explorers.Thankfully, this extra helper code does not need to be included in the modern or server bundles, but only in legacy code.