Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move meteorBabelHelpers to modules package, and restrict to legacy bundle. #10596

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Move meteorBabelHelpers to modules package, and restrict to legacy bundle. #10596

merged 1 commit into from
Jun 25, 2019

Commits on Jun 25, 2019

  1. Move meteorBabelHelpers to modules package, and restrict to legacy bu… 

    …ndle.

Should fix #10595.

Code from the application `node_modules` directory becomes part of the
`modules` package, so that it can be imported by any other package that
uses the module system, regardless of package load order.

Now that we compile code from `node_modules` using `babel-compiler` and
`meteor-babel` (#10585), `node_modules` code requires the same runtime
environment as any other Meteor JS code. For the most part, this need is
satisfied by the `@babel/runtime/helpers/...` modules, which are also
defined in the `modules` package because they come from `node_modules`.
However, in the legacy bundle, `meteorBabelHelpers.sanitizeForInObject` is
used to fix buggy for-in iteration in older Internet Explorers.

Thankfully, this extra helper code does not need to be included in the
modern or server bundles, but only in legacy code.
    Ben Newman committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    7cff9bc View commit details
    Browse the repository at this point in the history