Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meteorBabelHelpers is Undefined in the Cordova Bundle (iOS) in releases > 1.8.1 #11123

Open
d0liver opened this issue Jul 17, 2020 · 11 comments
Open
Labels
not-ready Something is missing, we are not able to work on this issue yet.

Comments

@d0liver
Copy link

d0liver commented Jul 17, 2020

I'm attempting to build for iOS (with Cordova on macOS) on any Meteor release above 1.8.1. Running the app in the iOS simulator produces a meteorBabelHelpers is undefined error coming from multiple Meteor packages using coffeescript like https://github.com/softwarerero/meteor-accounts-t9n and https://github.com/arillo/meteor-flow-router-helpers. I did some digging and it looks like meteorBabelHelpers was supposed to be exposed to node_modules in the legacy bundle here: #10596.

I'd guess that what's happening is that these are old packages that are now compiling with coffeescript@2.x and leaking out newer syntax to Babel (since coffeescript 2.x doesn't attempt to polyfill newer syntaxes), but meteorBabelHelpers isn't available in the legacy environment for Meteor packages.

@hexsprite
Copy link
Contributor

Hey, I had this same problem. I ended up forking the packages and adding this at the top of each .coffee file:

meteorBabelHelpers = Package.modules.meteorBabelHelpers

which solved the issue for me. I didn't have that many coffeescript packages.

I had filed some issues about this but there wasn't much interest in fixing it ;)

@d0liver
Copy link
Author

d0liver commented Jul 19, 2020

@hexsprite Thanks very much. I was able to get this working doing what you suggested. I'm going to leave this open though, because I think that this effectively breaks compatibility with CoffeeScript for users unless they're willing to maintain their own forks of integral packages.

@stale
Copy link

stale bot commented Aug 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Aug 21, 2020
@xet7
Copy link
Contributor

xet7 commented Aug 22, 2020

I do also get this error on IE11

@stale stale bot removed the stale-bot label Aug 22, 2020
@stale
Copy link

stale bot commented Oct 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Oct 31, 2020
@stale
Copy link

stale bot commented Nov 9, 2020

This issue has been automatically closed it has not had recent activity.

@stale stale bot closed this as completed Nov 9, 2020
@filipenevola
Copy link
Collaborator

Is the workaround suggested by @hexsprite enough?

@xet7
Copy link
Contributor

xet7 commented Nov 11, 2020

@filipenevola

No, legacy bundle and browser detection code is broken so that's why Meteor/Wekan does not currently work in IE11 at all. Those dependencies should be updated to upstream, or alternative working dependencies proposed.

@filipenevola
Copy link
Collaborator

Sorry @xet7, I'm confused here, are they the same issue?

Our devel branch (1.11.1) is passing on IE11 in our regressions tests running on BrowserStack as you can see here https://app.circleci.com/pipelines/github/meteor/meteor/450/workflows/bbcf6bcc-ccac-4569-8206-527311c70f20/jobs/49616

Test Group 11 (49616) - meteor:meteor 2020-11-12 16-11-10

Is our BrowserStack test reporting the incorrect result? Or is it something else like in this case #11163?

@filipenevola filipenevola reopened this Nov 12, 2020
@filipenevola filipenevola added the not-ready Something is missing, we are not able to work on this issue yet. label Nov 12, 2020
@xet7
Copy link
Contributor

xet7 commented Nov 13, 2020

@filipenevola

After I updated Wekan to meteor devel at wekan/wekan@9087bd6 , I still see undefined errors on IE at https://friend.wekan.team (test server running meteor devel, you can register account) like this:

meteor-undefined

Those errors are not visible at Firefox and MS Legacy Edge.

Maybe it's some dependency?

@StorytellerCZ
Copy link
Collaborator

Just to confirm, this only issue in IE11?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-ready Something is missing, we are not able to work on this issue yet.
Projects
None yet
Development

No branches or pull requests

5 participants