Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert for..of object loop to for..in range loop in client.coffee #3

Closed
wants to merge 1 commit into from

Conversation

doronrk
Copy link

@doronrk doronrk commented Sep 10, 2019

Since this PR to Meteor 1.8.2 meteor/meteor#10596, the client gives an error in client.coffee "ReferenceError: meteorBabelHelpers is not defined". There is more relevant discussion here for a similar issue: meteor/meteor#7184

This PR fixes the problem, but perhaps there is a more correct solution.

@mitar
Copy link
Member

mitar commented Sep 10, 2019

Maybe report this issue to Meteor first? It looks like unintended side effect of the change there? Or there might be some simpler fix? I do not understand why would this valid code fail here?

@doronrk
Copy link
Author

doronrk commented Sep 10, 2019

@mitar I'm having a hard time understanding this as well. Do you have time to check whether this issue happens for you as well with Meteor 1.8.2-beta.18?

@mitar
Copy link
Member

mitar commented Sep 19, 2019

I can confirm it does not work for me with 1.8.2-beta.18, nor with 1.8.2-rc.0. I reported this here: meteor/meteor#10522 (comment)

@mitar
Copy link
Member

mitar commented Sep 20, 2019

Package just had to be republished with latest Meteor. A new version is now available as 0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants