Add Closeable/AutoCloseable on Database & interface

[zorglube]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Added the interface AutoCloseable to the interfaces DataBase and DatabaseConnection , in order to provid the possibility to use Java try with resources.

[zorglube]

This PR is related to this Issue #2974

[zorglube]

@kataggart I need a first review please.

[zorglube]

@kataggart I need a first review please.

Please.

[kataggart]

thanks @zorglube it's in the queue to be reviewed.

[nvoxland]

It's looking good so far. Both already have close() methods on them, so it makes sense and won't impact the APIs.

You added the try with resources to the tests, you can add throws Exception to the test method signature vs. just logging the error like you have.

Besides that, I have a vague hope to someday remove the need for a "close()" interface from Database in general to make that class more about being a "dialect" vs. another layer of a connection. But that is already going to be a large enough change that it would be nice to have Autoclosable on Database for now.

[zorglube]

You added the try with resources to the tests, you can add throws Exception to the test method signature vs. just logging the error like you have.

I'll work on that, then ping you back.

[zorglube]

@nvoxland : I updated the unit tests. IF it's good for you, do you have any idea of when the code will be merge ?

[nvoxland]

It looks good, @zorglube . I made it a non-draft release and kicked off a build on it to make sure everything is still all passing. After those finish we have a couple other internal review & test steps but I'd imagine it will be in the next release. We generally shoot for a new release every couple weeks and just had one recently, so I'd guess it will be around then.

[nvoxland]

Code review and test results:

Things to be aware of:

• Only "shipped" change is adding the Closable interface to Database and DatabaseConnection. Both of which already defined the close() method so no real code impact beyond that extra marker interface.
• The rest of the changes are fixes to tests to avoid linters complaining about "not closing autoclosable objects"

Things to worry about:

• Nothing

[github-actions]

Unit Test Results

  4 608 files  ±0    4 608 suites  ±0   33m 23s ⏱️ - 3m 4s
  4 589 tests ±0    4 375 ✔️ ±0     214 💤 ±0  0 ❌ ±0 
54 240 runs  ±0  49 232 ✔️ ±0  5 008 💤 ±0  0 ❌ ±0 

Results for commit ad612b8. ± Comparison against base commit bcd2d53.

[XDelphiGrl]

• Fix enhances the existing 'close' method in Database and DatabaseConnection to add the ability to use Java try with resources .
• This PR is "noisy" with a lot of changes that came in from a merge.
  • Many changes normalize our usage of the changeset v. change set terminology.
  • Many other changes are related to using XSD latest & warning if XSD versions are mismatched.
  • Nothing to worry about, just noting that is why the number of changed files is large for a very focused change to the code.
• No additional testing necessary.

APPROVED

Passing Functional Tests
Passing Test Harness Execution

[zorglube]

Thanks guys! ☺️