Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoCloseable #469

Closed
wants to merge 1 commit into from
Closed

AutoCloseable #469

wants to merge 1 commit into from

Conversation

djechelon
Copy link

@djechelon djechelon commented Jul 30, 2015

I believe that every single Java class/interface that shows a close() method should extend AutoCloseable so that 1) it can be instantiated in a try-with-resources block and 2) raise a compiler warning (e.g. with Eclipse) if not disposed properly of

I believe that every single Java class/interface that shows a close() method should extend AutoCloseable so that 1) it can be instantiated in a try-with-resources block and 2) raise a compiler warning (e.g. with Eclipse) if not disposed properly of
@nvoxland nvoxland added this to the 4.0 milestone Aug 21, 2015
@nvoxland
Copy link
Contributor

With 3.x we're trying to keep Java 6 still. I'll add it to 4.0 which targets Java 7, though.

@bmarwell
Copy link

Hi, it's been some time and now it's java 8 which is almost out of support.

@datical-jenkins datical-jenkins changed the title AutoCloseable LB-89 ⁃ AutoCloseable Mar 4, 2020
@datical-jenkins datical-jenkins changed the title LB-89 ⁃ AutoCloseable AutoCloseable Mar 5, 2020
@ro-rah
Copy link

ro-rah commented May 13, 2020

Hi @djechelon ,

Would you resolve branch conflict and consider adding tests for this PR? Here's some guidance on that below:

Thanks for your pull request!

Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest:

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

@nvoxland nvoxland removed this from the 4.0 milestone Apr 14, 2021
@kataggart
Copy link
Contributor

@nvoxland is this resolved via #2990?

@kataggart kataggart added this to To Do in Conditioning++ via automation Jul 5, 2022
@kataggart kataggart self-assigned this Jul 5, 2022
@nvoxland
Copy link
Contributor

Yes, this is handled by #2990 and also taking the CSV library out of our code

@nvoxland nvoxland closed this Jul 15, 2022
Conditioning++ automation moved this from To Do to Done Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants