Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AutoCloseable connexion and database #9

Closed

Conversation

zorglube
Copy link
Contributor

@zorglube zorglube commented Jun 22, 2022

Can't be merge until Liquibase didn't release this PR liquibase/liquibase#2990 related to the issue liquibase/liquibase#2974

@zorglube zorglube force-pushed the handle_closeable_connexion_and_database branch from 7f1b530 to ad8c388 Compare June 22, 2022 15:56
@zorglube
Copy link
Contributor Author

Normally the next Liquibase release will include AutoCloseable interface.

example/pom.xml Outdated Show resolved Hide resolved
@zorglube
Copy link
Contributor Author

zorglube commented Aug 1, 2022

Still have to waite for the next Liquibase release.

@lbruun
Copy link
Owner

lbruun commented Aug 1, 2022

Still have to wait for the next Liquibase release.

It is not only about when this is released by the Liquibase project. More so it is a matter of when the Spring project updates their dependency version on Liquibase.

@zorglube
Copy link
Contributor Author

zorglube commented Aug 1, 2022

Still have to wait for the next Liquibase release.

It is not only about when this is released by the Liquibase project. More so it is a matter of when the Spring project updates their dependency version on Liquibase.

You're definitely right ;-)

@zorglube
Copy link
Contributor Author

Have to wait for a version of liquibase upper than https://github.com/liquibase/liquibase/releases/tag/v4.14.0

@lbruun
Copy link
Owner

lbruun commented Nov 26, 2022

Hi @zorglube. The project has been updated to use Spring Boot 3. This means that it now implicitly uses Liquibase 4.17.2 where your Liquibase PR is included. In other words: I think this PR can now proceed.

A fair amount of changes has happened in the mean time on Pre-Liquibase. Therefore, this PR needs to re-based.
Thx.

@zorglube
Copy link
Contributor Author

Ok, I'll have a look next week.

@zorglube zorglube force-pushed the handle_closeable_connexion_and_database branch from 245ee9f to a09a4a0 Compare November 28, 2022 16:26
@zorglube
Copy link
Contributor Author

Hello @lbruun ,

I'm definitely not sure of my rebase, please be carfull before merge.

@zorglube
Copy link
Contributor Author

Close in the benefit of : #19

@zorglube zorglube closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants