Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Closeable/AutoCloseable to the interface liquibase.database.Database #2974

Closed
zorglube opened this issue Jun 20, 2022 · 1 comment · Fixed by #2990
Closed

Add Closeable/AutoCloseable to the interface liquibase.database.Database #2974

zorglube opened this issue Jun 20, 2022 · 1 comment · Fixed by #2990

Comments

@zorglube
Copy link
Contributor

zorglube commented Jun 20, 2022

Environment

Liquibase Version: The incoming release.
Liquibase Integration & Version: All
Liquibase Extension(s) & Version: All
Database Vendor & Version: All
Operating System Type & Version: All
Infrastructure Type/Provider: All

Description

Hello,

Since I started working a few on the module Pre-Liquibase, I digged a few in Liquibase sources and I saw something that might be usefull.
Is this possible to add the interface java.io.IOException.Closeable to the interface interface liquibase.database.Database, that will allow to use Database in try with resources.

Actual Behavior

Since Database don't implement Closeable it's not possible to use it into try with resources.

Expected/Desired Behavior

Having the possibiliy to use Database into try with resources.

@kataggart kataggart added this to To Do in Conditioning++ via automation Jun 21, 2022
@zorglube zorglube changed the title Add Closeable to the interface liquibase.database.Database Add Closeable/AutoCloseable to the interface liquibase.database.Database Jun 23, 2022
@zorglube
Copy link
Contributor Author

I started a PR #2990

@kataggart kataggart linked a pull request Jun 23, 2022 that will close this issue
3 tasks
Conditioning++ automation moved this from To Do to Done Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants