Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maven-surefire-plugin from 3.0.0-M6 to 3.0.0-M7 #557

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 8, 2022

Bumps maven-surefire-plugin from 3.0.0-M6 to 3.0.0-M7.

Release notes

Sourced from maven-surefire-plugin's releases.

3.0.0-M7

🚀 New features and improvements

🐛 Bug Fixes

📦 Dependency updates

👻 Maintenance

Commits
  • fcdd766 [maven-release-plugin] prepare release surefire-3.0.0-M7
  • 559db4c [SUREFIRE-2086] Management of temporary files (#535)
  • bce6b43 [SUREFIRE-2067] Improve site configuration
  • ec47652 move this version changelog to a dedicated page (#539)
  • 535855a [SUREFIRE-2077] Allow consecutive spaces in argLine (#527)
  • 2cf4674 [SUREFIRE-2075] Only set thread count if spec'd
  • 7008175 Bump javacc from 7.0.10 to 7.0.11 (#524)
  • 03cafca Bump javassist from 3.22.0-GA to 3.29.0-GA
  • 8fa3098 [SUREFIRE-2083] Remove redundant config from maven-shade-plugin
  • 17628ad [SUREFIRE-2081] Upgrade Parent to 36
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.0.0-M6 to 3.0.0-M7.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.0.0-M6...surefire-3.0.0-M7)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 8, 2022
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

@dependabot dependabot bot merged commit b4b22a3 into master Jun 8, 2022
@dependabot dependabot bot deleted the dependabot/maven/org.apache.maven.plugins-maven-surefire-plugin-3.0.0-M7 branch June 8, 2022 17:11
@jglick
Copy link
Member

jglick commented Jun 13, 2022

FTR apache/maven-surefire#518 seems to fix a problem I had in jenkinsci/workflow-durable-task-step-plugin#180 noted in jglick/workflow-durable-task-step-plugin@c663479 whereby certain test idioms would cause what should have been a failing test to be treated as a successful build and thus lost unless you happened to be paying attention to the console.

Steps to reproduce
$ mvn -version
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: /home/jglick/.sdkman/candidates/maven/current
Java version: 11.0.15, vendor: Private Build, runtime: /usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-37-generic", arch: "amd64", family: "unix"
$ gh repo clone jglick/workflow-durable-task-step-plugin
Cloning into 'workflow-durable-task-step-plugin'...

$ cd workflow-durable-task-step-plugin/
$ git checkout 7231de1927543a395c39b118598bc26c6c6518d6
Note: switching to '7231de1927543a395c39b118598bc26c6c6518d6'.

You are in 'detached HEAD' state. …

HEAD is now at 7231de1 Merge branch 'stale-placeholdertask' into retry-JENKINS-49707
$ mvn test-compile
[INFO] Scanning for projects...

[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ workflow-durable-task-step ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 8 source files to /tmp/workflow-durable-task-step-plugin/target/test-classes
[INFO] 
[INFO] --- maven-hpi-plugin:3.27:test-hpl (default-test-hpl) @ workflow-durable-task-step ---
[INFO] Generating /tmp/workflow-durable-task-step-plugin/target/test-classes/the.hpl
[INFO] 
[INFO] --- maven-hpi-plugin:3.27:resolve-test-dependencies (default-resolve-test-dependencies) @ workflow-durable-task-step ---
[INFO] 
[INFO] --- gmavenplus-plugin:1.13.1:compileTests (test-in-groovy) @ workflow-durable-task-step ---
[INFO] No sources specified for compilation. Skipping.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.284 s
[INFO] Finished at: 2022-06-13T11:27:34-04:00
[INFO] ------------------------------------------------------------------------
$ mvn org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test -Dtest=ExecutorStepTest\#unrestorableAgent

[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-cli) @ workflow-durable-task-step ---
[INFO] Using auto detected provider org.apache.maven.surefire.junit4.JUnit4Provider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.jenkinsci.plugins.workflow.support.steps.ExecutorStepTest
=== Starting unrestorableAgent(org.jenkinsci.plugins.workflow.support.steps.ExecutorStepTest)

  15.340 [p #1] dumbo has been removed for 15 sec, assuming it is not coming back
  15.341 [p #1] Ready to run at Mon Jun 13 11:28:14 EDT 2022
  15.341 [p #1] [Pipeline] }
  15.392 [p #1] [Pipeline] // node
  15.469 [id=95]	INFO	o.j.p.workflow.job.WorkflowRun#finish: p #1 completed: ABORTED
  15.493 [p #1] [Pipeline] End of Pipeline
  15.494 [p #1] Agent was removed
  15.509 [p #1] Finished: ABORTED
  15.534 [id=107]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Stopping Jenkins
  15.638 [id=107]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Jenkins stopped
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.895 s - in org.jenkinsci.plugins.workflow.support.steps.ExecutorStepTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /tmp/workflow-durable-task-step-plugin/target/surefire-reports/2022-06-13T11-27-52_856-jvmRun1.dumpstream
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.991 s
[INFO] Finished at: 2022-06-13T11:28:15-04:00
[INFO] ------------------------------------------------------------------------
$ mvn org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test -Dtest=ExecutorStepTest\#unrestorableAgent

[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-cli) @ workflow-durable-task-step ---
[INFO] Using auto detected provider org.apache.maven.surefire.junit4.JUnit4Provider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.jenkinsci.plugins.workflow.support.steps.ExecutorStepTest
=== Starting unrestorableAgent(org.jenkinsci.plugins.workflow.support.steps.ExecutorStepTest)

  15.305 [p #1] dumbo has been removed for 15 sec, assuming it is not coming back
  15.306 [p #1] Ready to run at Mon Jun 13 11:29:33 EDT 2022

  15.356 [p #1] [Pipeline] }
  15.357 [p #1] [Pipeline] // node
  15.455 [id=98]	INFO	o.j.p.workflow.job.WorkflowRun#finish: p #1 completed: ABORTED
  15.458 [p #1] [Pipeline] End of Pipeline
  15.458 [p #1] Agent was removed
  15.491 [p #1] Finished: ABORTED
  15.523 [id=108]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Stopping Jenkins
  15.646 [id=108]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Jenkins stopped
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.916 s <<< FAILURE! - in org.jenkinsci.plugins.workflow.support.steps.ExecutorStepTest
[ERROR] org.jenkinsci.plugins.workflow.support.steps.ExecutorStepTest.unrestorableAgent  Time elapsed: 20.799 s  <<< FAILURE!
java.lang.AssertionError: 

Expected: a string containing "‘dumbo’ is offline"
     but: was "Started
[Pipeline] Start of Pipeline
[Pipeline] node
Running on dumbo in /tmp/workflow-durable-task-step-plugin/target/tmp/j h4119310188977467287/agent-work-dirs/dumbo/workspace/p
[Pipeline] {
[Pipeline] semaphore
Resuming build at Mon Jun 13 11:29:18 EDT 2022 after Jenkins restart
Waiting for reconnection of dumbo before proceeding with build
dumbo has been removed for 15 sec, assuming it is not coming back
Ready to run at Mon Jun 13 11:29:33 EDT 2022
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Agent was removed
Finished: ABORTED
"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:964)
	at org.junit.Assert.assertThat(Assert.java:930)
	at org.jvnet.hudson.test.JenkinsRule.assertLogContains(JenkinsRule.java:1535)
	at org.jvnet.hudson.test.JenkinsRule.waitForMessage(JenkinsRule.java:1583)
	at org.jenkinsci.plugins.workflow.support.steps.ExecutorStepTest.lambda$unrestorableAgent$16(ExecutorStepTest.java:518)
	at org.jvnet.hudson.test.JenkinsSessionRule$2.evaluate(JenkinsSessionRule.java:102)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:607)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:829)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   ExecutorStepTest.lambda$unrestorableAgent$16:518 
Expected: a string containing "‘dumbo’ is offline"
     but: was "…"
[INFO] 
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.453 s
[INFO] Finished at: 2022-06-13T11:29:34-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) on project workflow-durable-task-step: There are test failures.
[ERROR] 
[ERROR] Please refer to /tmp/workflow-durable-task-step-plugin/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants