Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2083] - Remove redundant config from maven-shade-plugin #532

Conversation

spannm
Copy link
Contributor

@spannm spannm commented May 6, 2022

This small PR removes redundant configuration from maven-shade-plugin in surefire-shared-utils.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put jira issue number in square brackets .. commit message and PR title

it is sometime important for tools ... 😄

@slawekjaranowski slawekjaranowski self-assigned this May 6, 2022
@spannm spannm changed the title SUREFIRE-2083: Remove redundant config from maven-shade-plugin [SUREFIRE-2083] - Remove redundant config from maven-shade-plugin May 6, 2022
@spannm spannm force-pushed the sman-81-SUREFIRE-2083-shade-plugin-configuration branch from b104dac to d1e0244 Compare May 6, 2022 17:14
@spannm
Copy link
Contributor Author

spannm commented May 6, 2022

please put jira issue number in square brackets .. commit message and PR title

Thanks for the feedback. Done

@Tibor17
Copy link
Contributor

Tibor17 commented May 6, 2022

yes it works this way
the content is the same except POM of course

@slawekjaranowski slawekjaranowski merged commit 8fa3098 into apache:master May 10, 2022
@spannm spannm deleted the sman-81-SUREFIRE-2083-shade-plugin-configuration branch July 9, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants