Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2077] Allow consecutive spaces in argLine #527

Merged

Conversation

mthmulders
Copy link
Contributor

@mthmulders mthmulders commented Apr 24, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
    SUREFIRE-2077
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Tibor17
Copy link
Contributor

Tibor17 commented Apr 25, 2022

@mthmulders mthmulders changed the title [SUREFIRE-2063] Allow consecutive spaces in argLine [SUREFIRE-2077] Allow consecutive spaces in argLine Apr 25, 2022
@mthmulders
Copy link
Contributor Author

Let's have the conversation in JIRA, and when we have a decision, see if this implementation (still) makes sense.

@Tibor17
Copy link
Contributor

Tibor17 commented Apr 25, 2022

The initial problem was with tabs in CLI. This was fixed in SUREFIRE-2063 but it was not a real fix because it was not a real bug. It was not a real bug, it was just an improvement because the CLI and the platform can see the tab as collision, in JPMS to be concrete, and hard to understand for most of the common users. Even Maarten did not understand the issue immediately and he found the cause finally. So we make these treatments in order to come over the user troubles.
We can argue in a loop and everybody may have a different opinion about these details on how to escape white space characters, and what characters should be considered as a replacement, etc.
I believe that having \t and maybe new line characters is the issue which origins in the POM itself and not in this code. So, if it is this place of the root cause then it should be fixed there as well. Maybe some warning would be helpful, and maybe enough, just my thoughts.

@olamy olamy added the bug label May 25, 2022
@olamy olamy merged commit 535855a into apache:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants