Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2067] Improve site configuration #538

Merged
merged 1 commit into from May 27, 2022
Merged

Conversation

slawekjaranowski
Copy link
Member

  • use banners from parent pom
  • use maven-fluido-skin version from parent
  • tob/side bar configuration from parent
  • remove dead link to privacy

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

- use banners from parent pom
- use maven-fluido-skin version from parent
- tob/side bar configuration from parent
- remove dead link to privacy
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shouldn't we use new version of fluido skin?

@slawekjaranowski
Copy link
Member Author

In parent pom 36 we have: maven-fluido-skin:1.10.0
If we want to use newer version (1.11.0) should be managed in parent not in each project separately.

@olamy
Copy link
Member

olamy commented May 26, 2022

In parent pom 36 we have: maven-fluido-skin:1.10.0 If we want to use newer version (1.11.0) should be managed in parent not in each project separately.

until the parent get released or we will wait long time.

@slawekjaranowski
Copy link
Member Author

In parent we collect many other things, like plugin versions etc ...
So we will have one update for parent not many updates in each projects.
We needn't wait wait long time - simply we can release next parent.

@slawekjaranowski slawekjaranowski merged commit bce6b43 into master May 27, 2022
@slawekjaranowski slawekjaranowski deleted the SUREFIRE-2067 branch May 27, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants