Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the translation function fully type-safe #1775

Merged
merged 14 commits into from Oct 19, 2022
Merged

Make the translation function fully type-safe #1775

merged 14 commits into from Oct 19, 2022

Conversation

pedrodurek
Copy link
Member

@pedrodurek pedrodurek commented May 13, 2022 •
edited by rosskevin

Closes #1504
Closes #1811

We'll no longer support typescript below v4.1

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@pedrodurek
Copy link
Member Author

pedrodurek commented May 13, 2022 •
edited

It's still pending to:

  • Add some tests for the new structure
  • Add some examples
  • Update documentation
  • Specify the breaking changes
  • Make some clean up

@pedrodurek pedrodurek mentioned this pull request May 13, 2022
Merged
5 tasks
@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 25, 2022
@pedrodurek
Copy link
Member Author

I'll update the remaining work this week

@stale stale bot removed the stale label May 30, 2022
@stale
Copy link

stale bot commented Jun 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2022
@JohnHallstrom
Copy link

Is there an ETA on this?

@stale stale bot removed the stale label Jun 16, 2022
@pedrodurek
Copy link
Member Author

pedrodurek commented Jun 16, 2022 •
edited

Hey @JohnHallstrom, I'm in the middle of the a moving houses process, but I intend to have everything in place by end of next week. Sorry for the delay ❤️

@JohnHallstrom
Copy link

Hey @JohnHallstrom, I'm in the middle of the a moving houses process, but I intend to have everything in place by end of next week. Sorry for the delay ❤️

That sounds great! I hope everything is going well with your move until then. Cheers!

@obritoluis
Copy link

This would be great! Any news or ETA?

@stale
Copy link

stale bot commented Jul 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 12, 2022
@adrai adrai removed the stale label Jul 30, 2022
@JohnHallstrom JohnHallstrom mentioned this pull request Aug 8, 2022
Closed
@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 8, 2022
@stale
Copy link

stale bot commented Sep 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 30, 2022
@CanRau
Copy link

CanRau commented Sep 30, 2022

It's still in process Staley, a little more patience please 🙏

@stale stale bot removed the stale label Sep 30, 2022
@stale
Copy link

stale bot commented Oct 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 12, 2022
@CanRau
Copy link

CanRau commented Oct 12, 2022

🥺

@CanRau
Copy link

CanRau commented Oct 14, 2022

Emoji isn't enough to please you 🤖 ?

@stale stale bot removed the stale label Oct 14, 2022
@adrai adrai added the pr hold label Oct 14, 2022
@pedrodurek pedrodurek mentioned this pull request Oct 18, 2022
Merged
7 tasks
@pedrodurek pedrodurek marked this pull request as ready for review October 18, 2022 05:39
@adrai adrai requested a review from rosskevin October 18, 2022 05:43
@pedrodurek
Copy link
Member Author

pedrodurek commented Oct 18, 2022 •
edited

Hey @adrai, it should be a Minor release. It'll probably not have any breaking changes, but I expect some devs to report bugs and/or limitations. I'll add examples later.

rosskevin
rosskevin requested changes Oct 18, 2022
View reviewed changes
test/typescript/t.test.ts Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@adrai
Copy link
Member

adrai commented Oct 18, 2022 •
edited

I would go with a major bump...
btw: is there something to be done in other repos, like react-i18next or next-i18next?

@rosskevin
Copy link
Collaborator

Yes, #1811 is actually about react-i18next, with that code move to this PR. The re-definition of TFunction should be removed there.

@adrai
Copy link
Member

adrai commented Oct 18, 2022

So if ok for you, I will merge this PR tomorrow morning and also create a new release.
Would be happy if you could check also for react-i18next and next-i18next afterwards. 🙏

@rosskevin
Copy link
Collaborator

@pedrodurek is already on it for react-i18next i18next/react-i18next#1501

I checked next-i18next and it does not need any changes.

@adrai adrai merged commit 1123110 into i18next:master Oct 19, 2022
@adrai
Copy link
Member

adrai commented Oct 19, 2022

included in v22.0.0

@adrai adrai mentioned this pull request Oct 20, 2022
Closed
@meyfa meyfa mentioned this pull request Oct 20, 2022
Closed
@adrai adrai mentioned this pull request Oct 20, 2022
Closed
@mikkisguy mikkisguy mentioned this pull request Feb 26, 2023
Closed
@mmattel mmattel mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin rosskevin approved these changes

Assignees
No one assigned
Labels
pr hold
Projects
None yet
Milestone
No milestone
7 participants
@pedrodurek @JohnHallstrom @obritoluis @coveralls @CanRau @adrai @rosskevin