Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0.0] Resources type is not exported anymore #1562

Closed
belgattitude opened this issue Oct 20, 2022 · 6 comments
Closed

[12.0.0] Resources type is not exported anymore #1562

belgattitude opened this issue Oct 20, 2022 · 6 comments
Assignees

Comments

@belgattitude
Copy link
Contributor

馃悰 Bug Report

> tsc --noEmit false --declaration --emitDeclarationOnly --outDir dist/types

src/types.ts:8:3 - error TS2305: Module '"react-i18next"' has no exported member 'Resources'.

To Reproduce

I think it's a breaking change... You can have a look to this PR and watch for the CI failure

i18next/next-i18next#1966

Your Environment

  • runtime version: i.e. node v14, deno, browser xy
  • i18next version: i.e. 19.5.3
  • os: Mac, Windows, Linux
  • any other relevant information
@adrai
Copy link
Member

adrai commented Oct 20, 2022

It's now probably part of i18next and not react-i18next anymore: i18next/i18next#1775 ?

@belgattitude
Copy link
Contributor Author

belgattitude commented Oct 20, 2022

Mmmh that will make it harder to support ranges of react-i18next and i18next in next-i18next... First intuition, It should be re-exported from react-i18next v12.0.0 to prevent bc. Or least be mentionned in the changelog

@pedrodurek
Copy link
Member

yep, we moved all types to i18next, where it should be since the very beginning. I put a PR adding a reference to the new doc. i18next/react-i18next-gitbook#140

@adrai
Copy link
Member

adrai commented Oct 21, 2022

So can this be closed @belgattitude ?

@belgattitude
Copy link
Contributor Author

Closed, thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants