Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update t function types to rely on types coming from i18next #1501

Merged
merged 5 commits into from Oct 20, 2022

Conversation

pedrodurek
Copy link
Member

@pedrodurek pedrodurek commented May 13, 2022

Dependent on i18next/i18next#1775

We'll no longer support typescript below v4.1

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 25, 2022
@pedrodurek pedrodurek removed the stale label May 25, 2022
@stale
Copy link

stale bot commented Jun 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 4, 2022
@pedrodurek pedrodurek removed the stale label Jun 9, 2022
@stale
Copy link

stale bot commented Jun 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 18, 2022
@pedrodurek pedrodurek removed the stale label Jun 26, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 10, 2022
@adrai adrai removed the stale label Jul 13, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2022
@pedrodurek pedrodurek removed the stale label Aug 3, 2022
@stale
Copy link

stale bot commented Aug 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 11, 2022
@pedrodurek pedrodurek removed the stale label Aug 12, 2022
@stale
Copy link

stale bot commented Sep 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 9, 2022
@pedrodurek pedrodurek removed the stale label Sep 15, 2022
@stale
Copy link

stale bot commented Sep 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 24, 2022
@pedrodurek pedrodurek removed the stale label Sep 27, 2022
@stale
Copy link

stale bot commented Oct 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 12, 2022
@develohpanda
Copy link

Bump, not stale! @pedrodurek what is blocking on this PR? Is there something I can do to help push it along?

For context the issue we are facing is the following, and going on the title of this PR it should fix the issue we are seeing.

image

@adrai adrai removed the stale label Oct 17, 2022
Copy link
Collaborator

@rosskevin rosskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is good to go. I'll leave a request change to bump the minimum i18next once i18next/i18next#1775 is released.

Thank you @pedrodurek

@pedrodurek pedrodurek marked this pull request as ready for review October 19, 2022 00:14
@adrai
Copy link
Member

adrai commented Oct 19, 2022

I believe this is good to go. I'll leave a request change to bump the minimum i18next once i18next/i18next#1775 is released.

Thank you @pedrodurek

v22.0.0 is now published

@adrai
Copy link
Member

adrai commented Oct 19, 2022

@pedrodurek let me know when this can be merged

@coveralls
Copy link

coveralls commented Oct 19, 2022

Coverage Status

Coverage remained the same at 95.862% when pulling ad82365 on pedrodurek:make-translation-type-safe into a0eed42 on i18next:master.

@pedrodurek
Copy link
Member Author

Hey @adrai, this is good now. It needs to be a Major release.

@pedrodurek
Copy link
Member Author

Later today (my timezone 😛), I'll update the react-i18next doc adding a reference to the i18next doc.

@adrai
Copy link
Member

adrai commented Oct 20, 2022

@rosskevin as soon as you approve, I'll create a new major version...

btw: in case you're interested: i18next/next-i18next#1966

@adrai adrai merged commit 3bfd803 into i18next:master Oct 20, 2022
@adrai
Copy link
Member

adrai commented Oct 20, 2022

Thank you for your contributions...
v12.0.0 has just been published.

@develohpanda
Copy link

Incredible; thank you all so much for such a quick turnaround! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants