Bump i18next from 21.10.0 to 22.0.4 in /services/idp #4941
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
need to test the compatibility, draft 4 now |
|
A newer version of i18next exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@fschade ping maybe you can re-review |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
Solved by applying master (recent changes in react-redux by @kulmann): |
mmattel
force-pushed
the
dependabot/npm_and_yarn/services/idp/i18next-22.0.4
branch
from
44ba7a8
to
a470f91
Compare
|
💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-1 failed. Further test are cancelled... |
Bumps [i18next](https://github.com/i18next/i18next) from 21.10.0 to 22.0.4. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v21.10.0...v22.0.4) --- updated-dependencies: - dependency-name: i18next dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
mmattel
force-pushed
the
dependabot/npm_and_yarn/services/idp/i18next-22.0.4
branch
from
cb69cc5
to
f93b0ff
Compare
mmattel
force-pushed
the
dependabot/npm_and_yarn/services/idp/i18next-22.0.4
branch
from
f93b0ff
to
9770930
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@kulmann As this is a major release, I would like to bring this to your attention. According the source page (i18next/i18next/pull/1775), the breaking change is: As I do not know if we are above v4.1 or not, I would like to handover the decision for pressing the merge button to you (or one from the web team) 😅 |
Web itself is on a newer TypeScript version, however, the IDP seems to use |
|
In general we could align the TypeScript version with the Web TypeScript version. Although not necessary, it would be nice for consistency, no? |
Basically nice for language feature consistency, yes, but I don't see how this can be in an issue as the idp code is completely independent from web. |
delete-merged-branch
bot
deleted the
dependabot/npm_and_yarn/services/idp/i18next-22.0.4
branch
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Florian Schade <f.schade@icloud.com> Co-authored-by: mmattel <github@diemattels.at>
Bumps i18next from 21.10.0 to 22.0.4.
Release notes
Sourced from i18next's releases.
Changelog
Sourced from i18next's changelog.
Commits
ecfa1bd22.0.48912f72changelog88c0231Add type for Formatter.addCached (#1862)f00b57c22.0.35cc60b1changelogc02b1aeOmit object fromtfunction (#1858)6d3156aMake getFixedT type-safe (#1860)96613fa22.0.26e0f7b3release0b74e8bAdd default for TDefaultResult (#1853)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)