Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 1.5.1: use of closed network connection, 1.5.0 is fine #877

Open
1 task done
bmhatfield opened this issue Nov 28, 2023 · 4 comments
Open
1 task done

[BUG] 1.5.1: use of closed network connection, 1.5.0 is fine #877

bmhatfield opened this issue Nov 28, 2023 · 4 comments
Labels

Comments

@bmhatfield
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

After upgrading from websocket 1.5.0 to 1.5.1, my service started regularly erroring with read tcp 10.40.0.207:8080->10.40.0.1:37429: use of closed network connection. Reverting back to 1.5.0 from 1.5.1 quieted these errors.

Expected Behavior

I expected 1.5.0 -> 1.5.1 to be a seamless upgrade, continuing to not error about use of closed network connection.

Steps To Reproduce

This may be hard to reproduce, as I am unsure if this was just unmasked in our code or if a new issue was introduced to gorilla/websocket in 1.5.1. I will update this issue if I am able to find a clean reproduce case. We have quite a bit of supporting code so the bug here could be entirely in our stack, not in gorilla/websocket.

However, a direct upgrade and then revert with no other corresponding changes which results in errors and then those errors going away seems like a good threshold to at least start a conversation.

Anything else?

I reviewed the existing issues and found:

However both these issues predate 1.5.0 and 1.5.1 by some margin.

@simon28082
Copy link

simon28082 commented Jan 4, 2024

I've had the same problem recently, I'll try to roll back to 1.5.0

@simon28082
Copy link

My own problem, solved.

@Hayden-Chang
Copy link

My own problem, solved.

Hi simon, could you describle how did you trigger this error and how did you resolved it?

@StevenACoffman
Copy link

@simon28082 I'm curious if you can summarize what caused and solved your problem, as I'm experiencing the same symptoms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants